fix: 'module' is not defined eslint error in template-react (fix #13517)#13518
Merged
patak-cat merged 1 commit intovitejs:mainfrom Jun 19, 2023
Merged
fix: 'module' is not defined eslint error in template-react (fix #13517)#13518patak-cat merged 1 commit intovitejs:mainfrom
patak-cat merged 1 commit intovitejs:mainfrom
Conversation
|
|
ArnaudBarre
approved these changes
Jun 18, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13517
This adds the
nodeenv to the.eslintrc.cjsfile inpackages/create-vite/template-reactandpackages/create-vite/template-react-tstemplates to fix the linter error'module' is not definedThere are a few other ways to fix this, but I think this way makes the most sense and does not affect the linting of other files in the project.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).