Skip to content

fix(create-vite): ts error in the svelte-ts template#16031

Merged
sapphi-red merged 1 commit intovitejs:mainfrom
twharmon:patch-1
Feb 27, 2024
Merged

fix(create-vite): ts error in the svelte-ts template#16031
sapphi-red merged 1 commit intovitejs:mainfrom
twharmon:patch-1

Conversation

@twharmon
Copy link
Copy Markdown
Contributor

Description

The ts compiler says that null is not assignable to target. This PR fixes that.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-cat patak-cat changed the title Fix ts error fix(create-vite): ts error in the svelte-ts template Feb 26, 2024
@sapphi-red sapphi-red added p4-important Violate documented behavior or significantly improves performance (priority) feat: create-vite create-vite package p3-minor-bug An edge case that only affects very specific usage (priority) and removed p4-important Violate documented behavior or significantly improves performance (priority) labels Feb 27, 2024
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sapphi-red sapphi-red merged commit ff4c834 into vitejs:main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: create-vite create-vite package p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants