feat(create-vite): add help usage #16390
Merged
bluwy merged 8 commits intovitejs:mainfrom Jun 17, 2024
Merged
Conversation
- help argument will be used as "--help" and by default it is false
- i want to find a way to decouple the text from the code
|
|
- Using alias to define template and help
bluwy
reviewed
May 18, 2024
Member
bluwy
left a comment
There was a problem hiding this comment.
Some formatting nits, otherwise a nice addition to me!
- To improve maintainability, the help message has been moved to a separate file. - Implemented the suggestions provided in the pull request.
Member
bluwy
approved these changes
Jun 13, 2024
Contributor
Author
Member
|
Yeah I did try that but to do so and others, it slows creeps in as a lot of code compared to hardcoding. So I leaned directly to the simplest way for now. |
Contributor
Author
Member
|
Yeah that was also the part where I threw my hand and went for the simpler path instead 😄 It's hard to sort that one with a specific hardcoding too. |
bluwy
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
closes #16374
