chore: add create-preact recommendation to Preact templates#17649
Merged
patak-cat merged 3 commits intovitejs:mainfrom Jul 14, 2024
Merged
chore: add create-preact recommendation to Preact templates#17649patak-cat merged 3 commits intovitejs:mainfrom
create-preact recommendation to Preact templates#17649patak-cat merged 3 commits intovitejs:mainfrom
Conversation
|
|
rschristian
changed the title
create-preact recommendation to Preact templatescreate-preact recommendation to Preact templates
patak-cat
approved these changes
Jul 13, 2024
Member
|
Sounds good! @rschristian, I think we should also add an option in the CLI when the user selects Preact. See how the user can jump to create-vue from create-vite. Let me know if you'd like to send another PR for this, or I can send it if not. |
patak-cat
added
feat: create-vite
Contributor
Author
|
Yep, can do! I held off as we don't yet support passing in the target directory, which means users will need to type the name in twice. Obviously a very quick fix, I just haven't had a moment to do it yet. Was going to make a separate PR here once that was added & released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Like the Vue template does, I think we, Preact, would prefer to nudge users towards our own initializer which offers a bit more Preact-specific functionality and allows us to control the defaults of a bit better.