Skip to content

fix(create-vite): move ESLint "ignores" config to a separate object in React templates#17885

Merged
bluwy merged 1 commit intovitejs:mainfrom
simonlary:react-template-eslint-ignores-fix
Aug 15, 2024
Merged

fix(create-vite): move ESLint "ignores" config to a separate object in React templates#17885
bluwy merged 1 commit intovitejs:mainfrom
simonlary:react-template-eslint-ignores-fix

Conversation

@simonlary
Copy link
Copy Markdown
Contributor

Description

fixes #17883

Simply put ignores in its own object to apply it to all configs by default, so the dist directory is correctly ignored.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluwy bluwy changed the title fix: move ESLint "ignores" config to a separate object in React templates (fixes #17883) fix(create-vite): move ESLint "ignores" config to a separate object in React templates Aug 15, 2024
@bluwy bluwy merged commit 1b3b702 into vitejs:main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React Typescript template's ESLint configuration doesn't correctly ignore dist directory

2 participants