feat(create-vite): official starters options naming#19163
Merged
sapphi-red merged 2 commits intomainfrom Jan 24, 2025
Merged
Conversation
sapphi-red
previously approved these changes
Jan 9, 2025
bluwy
previously approved these changes
Jan 9, 2025
Member
bluwy
left a comment
There was a problem hiding this comment.
Do we also want to update this together? Maybe "Extra Vite templates" and "Electron".
vite/packages/create-vite/src/index.ts
Lines 272 to 290 in 8639538
Member
Author
|
Ah, yes! Went with "Extra Vite Starters" to align with the other names. |
bluwy
approved these changes
Jan 24, 2025
sapphi-red
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Better naming for official starters, that will make even more sense after we merge: