fix(create-app): change index.html templates' favicon.svg href to absolute URL#2620
Merged
antfu merged 1 commit intovitejs:mainfrom Apr 4, 2021
Merged
fix(create-app): change index.html templates' favicon.svg href to absolute URL#2620antfu merged 1 commit intovitejs:mainfrom
antfu merged 1 commit intovitejs:mainfrom
Conversation
antfu
approved these changes
Apr 4, 2021
antfu
changed the title
patak-cat
approved these changes
Apr 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
Change index.html templates' favicon.svg href to absolute URL
href="/src/favicon.svg".When directly accessing the address of the non-root URL, the favicon cannot be found. (Microsoft Edge Version 89.0.774.57(Official build) (64-bit), but latest Chrome and Firefox are OK)