all: test fixes

Author: medvednikov

ci/common/runner.v

@@ -72,8 +72,23 @@ pub fn run(all_tasks map[string]Task) {
 	task_name := os.args[1]
 	if task_name == 'all' {
 		log.info(term.colorize(term.green, 'Run everything...'))
+		mut failed_tasks := []string{}
 		for tname, t in all_tasks {
-			t.run(tname)
+			cmd := '${self_command} ${tname}'
+			log.info('Start ${term.colorize(term.yellow, t.label)}, cmd: `${cmd}`')
+			start := time.now()
+			result := os.system(cmd)
+			dt := time.now() - start
+			if result != 0 {
+				log.error('FAILED ${term.colorize(term.red, t.label)} in ${dt.milliseconds()} ms, cmd: `${cmd}`')
+				failed_tasks << tname
+			} else {
+				log.info('Finished ${term.colorize(term.yellow, t.label)} in ${dt.milliseconds()} ms, cmd: `${cmd}`')
+			}
+		}
+		if failed_tasks.len > 0 {
+			log.error('${failed_tasks.len} task(s) failed: ${failed_tasks}')
+			exit(1)
 		}
 		exit(0)
 	}

cmd/tools/modules/testing/common.v

@@ -33,9 +33,13 @@ pub const show_longest_by_runtime = os.getenv('VTEST_SHOW_LONGEST_BY_RUNTIME').i
 pub const show_longest_by_comptime = os.getenv('VTEST_SHOW_LONGEST_BY_COMPTIME').int()
 pub const show_longest_by_totaltime = os.getenv('VTEST_SHOW_LONGEST_BY_TOTALTIME').int()
 
+pub const is_ci = os.getenv('CI') != '' || os.getenv('GITHUB_JOB') != ''
+
 pub const hide_skips = os.getenv('VTEST_HIDE_SKIP') == '1'
+	|| (is_ci && os.getenv('VTEST_HIDE_SKIP') != '0')
 
 pub const hide_oks = os.getenv('VTEST_HIDE_OK') == '1'
+	|| (is_ci && os.getenv('VTEST_HIDE_OK') != '0')
 
 pub const fail_fast = os.getenv('VTEST_FAIL_FAST') == '1'
 

cmd/tools/test_if_v_test_system_works.v

@@ -118,6 +118,7 @@ fn main() {
 		exit(1)
 	}()
 	println('> vroot: ${vroot} | vexe: ${vexe} | tdir: ${tdir}')
+	os.setenv('VTEST_HIDE_OK', '0', true)
 	ok_fpath := create_test('a_single_ok_test.v', 'fn test_ok(){ assert true }')!
 	if check_ok('${vexe} ${ok_fpath}') != '' {
 		exit(1)

cmd/tools/vdoc/testdata/output_formats/main.html

@@ -153,16 +153,24 @@ fn (selector VpmInstallServerSelector) metadata_server_urls() []string {
 
 fn get_ident_from_url(raw_url string) !(string, string) {
 	verbose_println_more(@FILE_LINE, @FN, 'raw_url: ${raw_url}')
+	// On Windows, absolute paths like `C:\...` are misinterpreted by urllib.parse
+	// (the drive letter `C:` is treated as a URL scheme). Handle local paths first.
+	if os.is_abs_path(raw_url) || raw_url.starts_with('./') || raw_url.starts_with('../')
+		|| raw_url.starts_with('~/') || raw_url.starts_with('.\\') || raw_url.starts_with('..\\') {
+		normalized := raw_url.replace('\\', '/')
+		_, name := normalized.rsplit_once('/') or {
+			return '', normalized.trim_string_right('.git')
+		}
+		return '', name.trim_string_right('.git')
+	}
 	url := urllib.parse(raw_url) or { return error('failed to parse module URL `${raw_url}`.') }
 	normalized_path := url.path.trim_left('/').trim_space()
 	publisher, mut name := normalized_path.rsplit_once('/') or {
 		if settings.vcs == .hg && raw_url.count(':') > 1 {
 			verbose_println_more(@FILE_LINE, @FN, 'ok, publisher: "", name: "test_module"')
 			return '', 'test_module'
 		}
-		if (url.scheme in ['file', ''] || os.is_abs_path(raw_url)
-			|| raw_url.starts_with('./') || raw_url.starts_with('../')
-			|| raw_url.starts_with('~/')) && normalized_path.len > 0 {
+		if url.scheme in ['file', ''] && normalized_path.len > 0 {
 			return '', normalized_path
 		}
 		final_error := 'failed to retrieve module name for `${url}`.'

cmd/tools/vpm/common.v

@@ -74,11 +74,15 @@ fn test_install_from_local_git_repository_variants() {
 	for i, c in cases {
 		vmodules_path := os.join_path(test_path, 'vmodules_case_${i}')
 		test_utils.set_test_env(vmodules_path)
-		mut cmd := '${vexe} install ${c.args}'
+		cmd := '${vexe} install ${c.args}'
+		old_dir := os.getwd()
 		if c.workdir != '' {
-			cmd = 'cd ${os.quoted_path(c.workdir)} && ${cmd}'
+			os.chdir(c.workdir) or { panic(err) }
 		}
 		res := cmd_ok(@LOCATION, cmd)
+		if c.workdir != '' {
+			os.chdir(old_dir) or {}
+		}
 		assert res.output.contains('Installed `${c.module_name}`'), res.output
 		manifest := vmod.from_file(os.join_path(vmodules_path, c.module_name, 'v.mod')) or {
 			panic('Failed to parse v.mod for `${c.module_name}`. ${err}')

cmd/tools/vpm/install_local_test.v

@@ -14,6 +14,18 @@ fn testsuite_end() {
 	os.rmdir_all(test_path) or {}
 }
 
+fn execute_in_dir(dir string, cmd string) os.Result {
+	old_dir := os.getwd()
+	os.chdir(dir) or { return os.Result{
+		exit_code: -1
+		output:    'failed to chdir: ${err}'
+	} }
+	defer {
+		os.chdir(old_dir) or {}
+	}
+	return os.execute(cmd)
+}
+
 fn test_link_and_unlink_current_project() {
 	module_name := 'author.coollib'
 	project_path := os.join_path(test_path, 'project')
@@ -28,7 +40,7 @@ fn test_link_and_unlink_current_project() {
 	}
 	link_path := os.join_path(test_path, 'author', 'coollib')
 
-	link_res := os.execute('cd ${os.quoted_path(project_subdir)} && ${vexe} link')
+	link_res := execute_in_dir(project_subdir, '${vexe} link')
 	if link_res.exit_code != 0 && is_symlink_privilege_error(link_res.output) {
 		eprintln('Skipping symlink test due to missing privileges.')
 		return
@@ -38,12 +50,12 @@ fn test_link_and_unlink_current_project() {
 	assert os.real_path(link_path) == os.real_path(project_path)
 	assert link_res.output.contains('Linked `${module_name}`'), link_res.output
 
-	link_again_res := os.execute('cd ${os.quoted_path(project_path)} && ${vexe} link')
+	link_again_res := execute_in_dir(project_path, '${vexe} link')
 	assert link_again_res.exit_code == 0, link_again_res.output
 	assert link_again_res.output.contains('already linked')
 		|| link_again_res.output.contains('already available'), link_again_res.output
 
-	unlink_res := os.execute('cd ${os.quoted_path(project_subdir)} && ${vexe} unlink')
+	unlink_res := execute_in_dir(project_subdir, '${vexe} unlink')
 	assert unlink_res.exit_code == 0, unlink_res.output
 	assert !os.exists(link_path) && !os.is_link(link_path)
 	assert !os.exists(os.join_path(test_path, 'author'))
@@ -56,7 +68,7 @@ fn test_link_without_vmod() {
 		assert false, err.msg()
 		return
 	}
-	res := os.execute('cd ${os.quoted_path(path)} && ${vexe} link')
+	res := execute_in_dir(path, '${vexe} link')
 	assert res.exit_code == 1, res.output
 	assert res.output.contains('no `v.mod` file found'), res.output
 }

cmd/tools/vpm/link_test.v

@@ -111,3 +111,21 @@ fn unique_server_urls(urls []string) []string {
 fn normalize_server_url(url string) string {
 	return url.trim_space().trim_string_right('/')
 }
+
+fn parse_server_urls(args []string) []string {
+	mut urls := []string{}
+	mut i := 0
+	for i < args.len {
+		if args[i] in server_url_option_names {
+			i++
+			if i < args.len {
+				url := normalize_server_url(args[i])
+				if url != '' && url !in urls {
+					urls << url
+				}
+			}
+		}
+		i++
+	}
+	return urls
+}

cmd/tools/vpm/settings.v

@@ -9,6 +9,7 @@ import rand
 import v.help
 import v.vmod
 
+const server_url_option_names = ['-m', '--mirror', '-server-url', '--server-url', '--server-urls']
 const settings = init_settings()
 const default_vpm_server_urls = ['https://vpm.vlang.io', 'https://vpm.url4e.com']
 const vpm_server_urls = rand.shuffle_clone(default_vpm_server_urls) or { [] } // ensure that all queries are distributed fairly

cmd/tools/vpm/vpm.v

@@ -16,6 +16,7 @@ fn testsuite_begin() {
 	os.setenv('VFLAGS', '', true)
 	os.setenv('VCOLORS', 'never', true)
 	os.setenv('VJOBS', '2', true)
+	os.setenv('VTEST_HIDE_OK', '0', true)
 	os.rmdir_all(tpath) or {}
 	os.mkdir_all(tpath)!