all: fix more tests

Author: medvednikov

vlib/gg/streaming_image_gl_test.v

@@ -34,7 +34,15 @@ fn test_streaming_r8_zero_buffer_stays_black_on_gl_backend() {
 	assert compile_res.exit_code == 0, compile_res.output
 	run_cmd := 'VGG_STOP_AT_FRAME=2 VGG_SCREENSHOT_FRAMES=2 VGG_SCREENSHOT_FOLDER=${os.quoted_path(temp_dir)} ${os.quoted_path(exe_path)}'
 	run_res := os.execute(run_cmd)
-	assert run_res.exit_code == 0, run_res.output
+	if run_res.exit_code != 0 {
+		if run_res.output.contains('glpixelformat') || run_res.exit_code == 134 {
+			// OpenGL context creation failed (e.g. headless CI runners without GPU).
+			// Skip the test rather than failing.
+			eprintln('skipping: GL context creation failed on this system')
+			return
+		}
+		assert run_res.exit_code == 0, run_res.output
+	}
 	screenshot_path := os.join_path(temp_dir, 'issue10989_repro_2.png')
 	assert os.exists(screenshot_path)
 	assert png_has_non_black_pixels(screenshot_path)! == false

vlib/v/ast/table.v

@@ -2644,8 +2644,11 @@ pub fn (mut t Table) convert_generic_type(generic_type Type, generic_names []str
 	return none
 }
 
-fn (mut t Table) lower_mut_param_type(typ Type) Type {
-	mut lowered := if typ.is_ptr() {
+fn (mut t Table) lower_mut_param_type(typ Type, orig_typ ...Type) Type {
+	// When the pointer came from the generic type argument itself (T=&int),
+	// not from the param signature (&T), we need ref() to add one more level.
+	orig_was_ptr := orig_typ.len > 0 && orig_typ[0].nr_muls() > 0
+	mut lowered := if typ.is_ptr() && !orig_was_ptr {
 		typ.ref()
 	} else {
 		typ.set_nr_muls(1)
@@ -2660,7 +2663,7 @@ pub fn (mut t Table) convert_generic_param_type(param Param, generic_names []str
 	if param.is_mut && param.orig_typ != 0 && param.orig_typ.has_flag(.generic)
 		&& to_types.all(!it.has_flag(.generic)) {
 		if typ := t.convert_generic_type(param.orig_typ, generic_names, to_types) {
-			return t.lower_mut_param_type(typ)
+			return t.lower_mut_param_type(typ, param.orig_typ)
 		}
 	}
 	return t.convert_generic_type(param.typ, generic_names, to_types)

vlib/v/gen/c/fn.v

@@ -1623,7 +1623,10 @@ fn (mut g Gen) fn_decl_params(params []ast.Param, scope &ast.Scope, is_variadic
 		if param.is_mut && param.orig_typ != 0 && param.orig_typ.has_flag(.generic)
 			&& param.typ.has_flag(.generic) {
 			mut surface_typ := g.unwrap_generic(param.orig_typ)
-			typ = if surface_typ.is_ptr() {
+			// Only use ref() when the pointer comes from the generic type argument
+			// (T=&int), not from the param signature (&T / ?&T).
+			orig_was_ptr := param.orig_typ.nr_muls() > 0
+			typ = if surface_typ.is_ptr() && !orig_was_ptr {
 				surface_typ.ref()
 			} else {
 				surface_typ.set_nr_muls(1)

vlib/v/generics/new_generics_regression_test.v

@@ -117,10 +117,10 @@ fn run_new_generic_solver_tests(root_label string, test_cmd string, expected_sum
 	println('')
 }
 
-const expected_summsvc_generics = 'Summary for all V _test.v files: 110 failed, 177 passed, 287 total.'
+const expected_summsvc_generics = 'Summary for all V _test.v files: 108 failed, 179 passed, 287 total.'
 // The exact failure count varies slightly across compilers:
-// gcc/tcc: 108, clang: 109, msvc/windows-gcc: 110.
-const expected_summary_generics = 'Summary for all V _test.v files: 108 failed, 179 passed, 287 total.'
+// gcc/tcc: 106, clang: 107, msvc/windows-gcc: 108.
+const expected_summary_generics = 'Summary for all V _test.v files: 106 failed, 181 passed, 287 total.'
 const expected_summsvc_vec = 'Summary for all V _test.v files: 3 failed, 3 total.'
 const expected_summary_vec = 'Summary for all V _test.v files: 3 failed, 3 total.'
 const expected_summsvc_flag = 'Summary for all V _test.v files: 21 passed, 21 total.'
@@ -158,7 +158,6 @@ const failing_tests = [
 	'vlib/v/tests/generics/generic_receiver_embed_test.v',
 	'vlib/v/tests/generics/generic_recursive_fn_test.v',
 	'vlib/v/tests/generics/generic_resolve_test.v',
-	'vlib/v/tests/generics/generic_return_array_generic_test.v',
 	'vlib/v/tests/generics/generic_return_test.v',
 	'vlib/v/tests/generics/generic_selector_field_test.v',
 	'vlib/v/tests/generics/generic_selector_indexexpr_test.v',