Implicit copy constructor call removal (#3003)

Tytus Bierwiaczonek · web-flow · commit 61c4d39e5ca7 · 2023-05-09T10:31:27.000+02:00
* Implicit copy constructor call removal
diff --git a/bftengine/src/bftengine/ReplicaImp.cpp b/bftengine/src/bftengine/ReplicaImp.cpp
@@ -1059,7 +1059,7 @@ void ReplicaImp::onMessage<PrePrepareMsg>(PrePrepareMsgUPtr msg) {
              "etc...)");
     return;
   }
-  PrePrepareMsgShPtr message = std::make_shared<PrePrepareMsg>(msg.release());
+  PrePrepareMsgShPtr message(std::move(msg));
   if (!getReplicaConfig().prePrepareFinalizeAsyncEnabled) {
     if (!validatePreProcessedResults(message.get(), getCurrentView())) {
       // trigger view change

Original file line number	Diff line number	Diff line change
`@@ -1059,7 +1059,7 @@ void ReplicaImp::onMessage<PrePrepareMsg>(PrePrepareMsgUPtr msg) {`
`1059`	`1059`	`"etc...)");`
`1060`	`1060`	`return;`
`1061`	`1061`	`}`
`1062`		`- PrePrepareMsgShPtr message = std::make_shared<PrePrepareMsg>(msg.release());`
	`1062`	`+ PrePrepareMsgShPtr message(std::move(msg));`
`1063`	`1063`	`if (!getReplicaConfig().prePrepareFinalizeAsyncEnabled) {`
`1064`	`1064`	`if (!validatePreProcessedResults(message.get(), getCurrentView())) {`
`1065`	`1065`	`// trigger view change`