fix: correct color marker when output to hook.sh script

Author: vnphanquang

.changeset/funny-clocks-fry.md

@@ -0,0 +1,5 @@
+---
+"@vnphanquang/githooks": patch
+---
+
+escape to correct color marker in `hook.sh`

deno.json

@@ -1,6 +1,6 @@
 {
 	"name": "@vnphanquang/githooks",
-	"version": "1.0.2",
+	"version": "1.0.3",
 	"exports": {
 		".": "./src/mod.ts",
 		"./bin": "./src/bin.ts",
@@ -17,7 +17,7 @@
 	},
 	"tasks": {
 		"init": "deno run --allow-read --allow-write=\".githooks\" --allow-run=\"git\" src/bin.ts init",
-		"test": "deno test --allow-read --allow-write --allow-run --allow-net --clean --coverage",
+		"test": "deno test -A --clean --coverage",
 		"coverage": "deno coverage --html",
 		"changesets": "deno run -A npm:@changesets/cli",
 		"ci:test": "deno test -A --clean --coverage=coverage",

src/constants.ts

@@ -58,13 +58,13 @@ export const GITHOOKS_SCRIPT: string = `\
 #!/usr/bin/env sh
 [ "$GITHOOKS" = "2" ] && set -x
 
-# skip if GITHOOKS_CURRENT_HOOK not set
 hook_script=$(dirname "$(dirname "$0")")/\${GITHOOKS_CURRENT_HOOK:-$(basename "$0")}
 
 # skip if hook has not been setup
 [ ! -f "$hook_script" ] && exit 0
 
-[ -z "$GITHOOKS_CURRENT_HOOK" ] && echo -e "\e[33mWarning: unset GITHOOKS_CURRENT_HOOK. Hook may not function properly. Check "$0"\e[0m"
+# warn if GITHOOKS_CURRENT_HOOK not set
+[ -z "$GITHOOKS_CURRENT_HOOK" ] && echo -e "\\e[33mWarning: unset GITHOOKS_CURRENT_HOOK. Hook may not function properly. Check "${GITHOOKS_UNDERSCORED_DIRNAME}/$(basename "$0")"\\e[0m"
 
 # source the global init script if any
 init_script="\${XDG_CONFIG_HOME:-$HOME/.config}/githooks/init"

tests/init.test.ts

@@ -8,6 +8,7 @@ import { GIT_HOOKS, GITHOOKS_DIRNAME, GITHOOKS_UNDERSCORED_DIRNAME } from '../sr
 import { NotGitDirectoryError } from '../src/errors.ts';
 import { init } from '../src/init.ts';
 import { git } from '../src/git.ts';
+import { GITHOOKS_SCRIPT_NAME } from '../src/constants.ts';
 
 Deno.test({
 	name: 'run "init" in non-git directory',
@@ -193,6 +194,23 @@ Deno.test({
 	},
 });
 
+async function expectCommonCommit() {
+	// write
+	await Deno.writeTextFile('main.ts', 'console.log("hello")');
+
+	// add
+	const { success } = await git(Deno.cwd(), 'add', 'main.ts').output();
+	expect(success).toBe(true);
+
+	// commit
+	return await git(
+		Deno.cwd(),
+		'commit',
+		'-m',
+		'test pre-commit hook',
+	).output();
+}
+
 Deno.test({
 	name: 'git commit should trigger pre-commit hook',
 	permissions: {
@@ -207,21 +225,75 @@ Deno.test({
 			await expectCommonGitInit(Deno.cwd(), true);
 			await expectCommonInit(Deno.cwd());
 
-			await Deno.writeTextFile('main.ts', 'console.log("hello")');
+			const { success, stderr } = await expectCommonCommit();
+			expect(new TextDecoder().decode(stderr)).toContain('Checked 1 file');
+			expect(success).toBe(true);
+		} finally {
+			await sbox[Symbol.asyncDispose]();
+		}
+	},
+});
+
+Deno.test({
+	name: 'GITHOOKS=0 should skip hook',
+	permissions: {
+		read: true,
+		write: true,
+		run: true,
+		env: true,
+	},
+	async fn() {
+		await using sbox = await sandbox();
+
+		try {
+			await expectCommonGitInit(Deno.cwd(), true);
+			await expectCommonInit(Deno.cwd());
 
-			// add
-			const { success } = await git(Deno.cwd(), 'add', 'main.ts').output();
+			Deno.env.set('GITHOOKS', '0');
+			const { success, stderr } = await expectCommonCommit();
+			expect(new TextDecoder().decode(stderr)).not.toContain('Checked 1 file');
 			expect(success).toBe(true);
+		} finally {
+			await sbox[Symbol.asyncDispose]();
+			Deno.env.delete('GITHOOKS');
+		}
+	},
+});
 
-			// commit
-			const { success: commitSuccess, stderr } = await git(
-				Deno.cwd(),
-				'commit',
-				'-m',
-				'test pre-commit hook',
-			).output();
-			expect(new TextDecoder().decode(stderr)).toContain('Checked 1 file');
-			expect(commitSuccess).toBe(true);
+Deno.test({
+	name: 'unset GITHOOKS_CURRENT_HOOK should warn user',
+	permissions: {
+		read: true,
+		write: true,
+		run: true,
+		env: true,
+	},
+	async fn() {
+		await using sbox = await sandbox();
+
+		try {
+			await expectCommonGitInit(Deno.cwd(), true);
+			await expectCommonInit(Deno.cwd());
+
+			await Deno.writeTextFile('main.ts', 'console.log("hello")');
+
+			// overwrite pre-commit
+			const script = `\
+#!/usr/bin/env sh
+. "$(dirname "$0")/${GITHOOKS_SCRIPT_NAME}" $@
+`;
+			await Deno.writeTextFile(
+				path.join(Deno.cwd(), GITHOOKS_UNDERSCORED_DIRNAME, 'pre-commit'),
+				script,
+			);
+
+			const { success, stderr } = await expectCommonCommit();
+			const err = new TextDecoder().decode(stderr);
+			expect(err).toContain('Checked 1 file');
+			expect(err).toContain(
+				'unset GITHOOKS_CURRENT_HOOK. Hook may not function properly.',
+			);
+			expect(success).toBe(true);
 		} finally {
 			await sbox[Symbol.asyncDispose]();
 		}