Skip to content

Commit 4f3ee9e

Browse files
committed
enhance(async-stack): use dialog.requestClose instead of dialog.close, if available
1 parent 93c7d99 commit 4f3ee9e

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

.changeset/stale-suns-try.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@svelte-put/async-stack': patch
3+
---
4+
5+
call `requestClose` if available in enhance-dialog

packages/async-stack/src/helpers/enhance-dialog.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,11 @@ export function enhanceDialog(item, options) {
3939
if (dialog.open) {
4040
// user calls `item.resolve(...)`
4141
dialog.removeEventListener('close', onclose);
42-
// TODO: change to https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/requestClose
43-
dialog.close();
42+
if ('requestClose' in dialog) {
43+
dialog.requestClose();
44+
} else {
45+
dialog.close();
46+
}
4447
}
4548
resumeResolution = resolve;
4649
}),
@@ -100,5 +103,9 @@ function onclick(event) {
100103
*/
101104
function onclickbackdrop(event) {
102105
const dialog = /** @type {HTMLDialogElement} */ (event.currentTarget);
103-
dialog.close();
106+
if ('requestClose' in dialog) {
107+
dialog.requestClose();
108+
} else {
109+
dialog.close();
110+
}
104111
}

0 commit comments

Comments
 (0)