refactor(toc): setAttribute -> toggleAttribute for toc markers

Quang Phan · Quang Phan · commit 80730b40ede5 · 2023-01-18T19:40:50.000+07:00
diff --git a/.changeset/wicked-jokes-arrive.md b/.changeset/wicked-jokes-arrive.md
@@ -0,0 +1,5 @@
+---
+'@svelte-put/toc': patch
+---
+
+refator to `toggleAttribute` in favor of `setAttribute` for markers
diff --git a/packages/actions/toc/src/lib/toc.action.ts b/packages/actions/toc/src/lib/toc.action.ts
@@ -162,7 +162,7 @@ export const toc: Action<HTMLElement, TocParameters, TocEventAttributes> = funct
         }
 
         // mark that this element has been processed by `toc`
-        element.setAttribute(ATTRIBUTES.toc, '');
+        element.toggleAttribute(ATTRIBUTES.toc, true);
       }
       cache[id] = { parameters: resolved, items };
     }
diff --git a/packages/actions/toc/src/lib/toc.internal.ts b/packages/actions/toc/src/lib/toc.internal.ts
@@ -127,7 +127,7 @@ export function processAnchor(
           element.parentNode?.insertBefore(a, element.nextSibling);
           break;
       }
-      a.setAttribute(ATTRIBUTES.anchor, '');
+      a.toggleAttribute(ATTRIBUTES.anchor, true);
     } else {
       // already processed by `@svelte-put/preprocess-auto-slug`
       // search for the injected anchor element

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@svelte-put/toc': patch
 +---
++
 +refator to `toggleAttribute` in favor of `setAttribute` for markers
Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ export const toc: Action<HTMLElement, TocParameters, TocEventAttributes> = funct`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	// mark that this element has been processed by `toc`
`165`		`- element.setAttribute(ATTRIBUTES.toc, '');`
	`165`	`+ element.toggleAttribute(ATTRIBUTES.toc, true);`
`166`	`166`	`}`
`167`	`167`	`cache[id] = { parameters: resolved, items };`
`168`	`168`	`}`
Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ export function processAnchor(`
`127`	`127`	`element.parentNode?.insertBefore(a, element.nextSibling);`
`128`	`128`	`break;`
`129`	`129`	`}`
`130`		`- a.setAttribute(ATTRIBUTES.anchor, '');`
	`130`	`+ a.toggleAttribute(ATTRIBUTES.anchor, true);`
`131`	`131`	`} else {`
`132`	`132`	// already processed by `@svelte-put/preprocess-auto-slug`
`133`	`133`	`// search for the injected anchor element`