Skip to content

Commit 9411dbf

Browse files
Merge pull request #9 from Vacant2333/remove-pod-group
chore: remove the pod group
2 parents 9bea166 + 40362f0 commit 9411dbf

File tree

17 files changed

+153
-455
lines changed

17 files changed

+153
-455
lines changed

cmd/controller-manager/main.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,8 @@ import (
3535
"volcano.sh/volcano/pkg/version"
3636

3737
_ "volcano.sh/volcano/pkg/controllers/garbagecollector"
38-
_ "volcano.sh/volcano/pkg/controllers/job"
39-
_ "volcano.sh/volcano/pkg/controllers/podgroup"
4038
_ "volcano.sh/volcano/pkg/controllers/queue"
4139

42-
_ "volcano.sh/volcano-global/pkg/controllers/deployment"
4340
_ "volcano.sh/volcano-global/pkg/dispatcher"
4441
)
4542

docs/deploy/README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ the introduction of some `Volcano` CRDs to enable the **queue capability** for t
126126

127127
Required `Volcano` CRD List:
128128
- batch.volcano.sh_jobs
129-
- scheduling.volcano.sh_podgroups
130129
- scheduling.volcano.sh_queues
131130
- bus.volcano.sh_commands
132131

@@ -136,7 +135,6 @@ export KUBECONFIG=$HOME/.kube/karmada.config
136135

137136
# Apply the required CRD to Karmada control plane.
138137
kubectl --context karmada-apiserver apply -f https://github.com/volcano-sh/volcano/raw/release-1.10/installer/helm/chart/volcano/crd/bases/batch.volcano.sh_jobs.yaml
139-
kubectl --context karmada-apiserver apply -f https://github.com/volcano-sh/volcano/raw/release-1.10/installer/helm/chart/volcano/crd/bases/scheduling.volcano.sh_podgroups.yaml
140138
kubectl --context karmada-apiserver apply -f https://github.com/volcano-sh/volcano/raw/release-1.10/installer/helm/chart/volcano/crd/bases/scheduling.volcano.sh_queues.yaml
141139
kubectl --context karmada-apiserver apply -f https://github.com/volcano-sh/volcano/raw/release-1.10/installer/helm/chart/volcano/crd/bases/bus.volcano.sh_commands.yaml
142140
```

docs/deploy/exmaple/mindspore-cpu.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ spec:
1515
maxRetry: 5
1616
queue: default
1717
tasks:
18-
- replicas: 8
18+
- replicas: 2
1919
name: "pod"
2020
template:
2121
spec:
@@ -26,7 +26,7 @@ spec:
2626
name: mindspore-cpu-job
2727
resources:
2828
limits:
29-
cpu: "0.1"
29+
cpu: "0.25"
3030
requests:
31-
cpu: "0.1"
31+
cpu: "0.25"
3232
restartPolicy: OnFailure

pkg/controllers/deployment/deployment_controller.go

Lines changed: 0 additions & 143 deletions
This file was deleted.

pkg/controllers/deployment/deployment_controller_handlers.go

Lines changed: 0 additions & 104 deletions
This file was deleted.

pkg/controllers/deployment/utils.go

Lines changed: 0 additions & 38 deletions
This file was deleted.

pkg/dispatcher/api/resource_binding_info.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ package api
1919
import (
2020
workv1alpha2 "github.com/karmada-io/karmada/pkg/apis/work/v1alpha2"
2121
"k8s.io/apimachinery/pkg/types"
22-
schedulingv1beta1 "volcano.sh/apis/pkg/apis/scheduling/v1beta1"
2322
)
2423

2524
type DispatchStatus int16
@@ -31,23 +30,24 @@ const (
3130
)
3231

3332
type ResourceBindingInfo struct {
34-
ResourceBinding *workv1alpha2.ResourceBinding
35-
36-
ResourceUID types.UID
37-
Queue string
38-
Priority int32
39-
PodGroup *schedulingv1beta1.PodGroup
40-
41-
DispatchStatus DispatchStatus
33+
ResourceBinding *workv1alpha2.ResourceBinding
34+
ResourceUID types.UID
35+
Queue string
36+
PriorityClassName string
37+
DispatchStatus DispatchStatus
38+
39+
// Update it when snapshot.
40+
Priority int32
4241
}
4342

4443
func (rbi *ResourceBindingInfo) DeepCopy() *ResourceBindingInfo {
4544
return &ResourceBindingInfo{
46-
ResourceBinding: rbi.ResourceBinding.DeepCopy(),
47-
ResourceUID: rbi.ResourceUID,
48-
Queue: rbi.Queue,
49-
Priority: rbi.Priority,
50-
PodGroup: rbi.PodGroup.DeepCopy(),
51-
DispatchStatus: rbi.DispatchStatus,
45+
ResourceBinding: rbi.ResourceBinding.DeepCopy(),
46+
ResourceUID: rbi.ResourceUID,
47+
Queue: rbi.Queue,
48+
PriorityClassName: rbi.PriorityClassName,
49+
DispatchStatus: rbi.DispatchStatus,
50+
51+
Priority: rbi.Priority,
5252
}
5353
}

0 commit comments

Comments
 (0)