Add poolsize back (undocumented) to help people notice they need to change things.

Author: oranenj

manifests/init.pp

@@ -70,6 +70,7 @@
   $mysql_connector_format                                           = 'tar.gz',
   Stdlib::Absolutepath $mysql_connector_install                     = '/opt/MySQL-connector',
   Stdlib::HTTPUrl $mysql_connector_url                              = 'https://dev.mysql.com/get/Downloads/Connector-J',
+  Optional[Integer[0]] $poolsize                                    = undef,
   Optional[Integer[0]] $pool_min_size                               = undef,
   Optional[Integer[0]] $pool_max_size                               = undef,
   Optional[Integer[-1]] $pool_max_wait                              = undef,
@@ -174,6 +175,14 @@
     $jvm_extra_args_real = $jvm_extra_args
   }
 
+  # Allow some backwards compatibility;
+  if $poolsize {
+    deprecation('jira::poolsize', 'jira::poolsize is deprecated and simply sets max-pool-size. Please use jira::pool_max_size instead and remove this configuration')
+    $pool_max_size_real = pick($pool_max_size, $poolsize)
+  } else {
+    $pool_max_size_real = $pool_max_size
+  }
+
   if $tomcat_redirect_https_port {
     unless ($tomcat_native_ssl) {
       fail('You need to set native_ssl to true when using tomcat_redirect_https_port')

templates/dbconfig.xml.epp

@@ -17,8 +17,8 @@
 <% if $jira::pool_min_size != undef { -%>
     <pool-min-size><%= $jira::pool_min_size %></pool-min-size>
 <% } -%>
-<% if $jira::pool_max_size != undef { -%>
-    <pool-max-size><%= $jira::pool_max_size %></pool-max-size>
+<% if $jira::pool_max_size_real != undef { -%>
+    <pool-max-size><%= $jira::pool_max_size_real %></pool-max-size>
 <% } -%>
 <% if $jira::pool_max_idle != undef { -%>
     <pool-max-idle><%= $jira::pool_max_idle %></pool-max-idle>