facts.pp: use localhost instead of 127.0.0.1

This way we don't discriminate against IPv6-only configurations.

Author: kenyon

manifests/facts.pp

@@ -21,7 +21,7 @@
   $json_packages = $jira::params::json_packages,
   # lint:ignore:parameter_order
   $uri           = $jira::tomcat_address ? {
-    undef   => '127.0.0.1',
+    undef   => 'localhost',
     default => $jira::tomcat_address,
   },
   # lint:endignore

spec/classes/jira_facts_spec.rb

@@ -10,7 +10,7 @@
 
         regexp_pe = %r{^#\!/opt/puppet/bin/ruby$}
         regexp_oss = %r{^#\!/opt/puppetlabs/puppet/bin/ruby$}
-        regexp_url = %r{http://127.0.0.1\:8080/rest/api/2/serverInfo}
+        regexp_url = Regexp.new(Regexp.escape('http://localhost:8080/rest/api/2/serverInfo'))
         external_fact_file = '/etc/puppetlabs/facter/facts.d/jira_facts.rb'
 
         it { is_expected.to contain_file(external_fact_file) }
@@ -48,7 +48,7 @@
 
           it do
             is_expected.to contain_file(external_fact_file). \
-              with_content(%r{  url = 'http://127.0.0.1:8080/jira})
+              with_content(%r{  url = 'http://localhost:8080/jira})
           end
         end
       end