fix(runtime-core): ensure suspense content inherit scopeId#10652
Merged
yyx990803 merged 3 commits intovuejs:mainfrom Aug 19, 2024
Merged
fix(runtime-core): ensure suspense content inherit scopeId#10652yyx990803 merged 3 commits intovuejs:mainfrom
yyx990803 merged 3 commits intovuejs:mainfrom
Conversation
Size ReportBundles
Usages
|
edison1105
changed the title
Member
Author
|
/ecosystem-ci run |
Contributor
|
📝 Ran ecosystem CI: Open
|
Member
Author
|
/ecosystem-ci run |
Contributor
|
📝 Ran ecosystem CI: Open
|
Contributor
|
@edison1105 Sorry for pinging you again. May we have this PR labeled as "ready to review" to attract a bit more of attention by potential reviewers now that we're starting with the v3.5.z cycle? The original issue has been open for 3 years and it's labeled as priority 4, so definitely this PR is worth it! |
Contributor
|
@yyx990803 Sorry for the ping, but can we get a review on this to hopefully have this in before 3.5.0 stable? As stated above, Suspense has long-standing issues with Transition for years and this is a simple fix that will get it finally resolved. |
Contributor
|
@yyx990803 Thank you very much!! 🚀🚀🚀🚀 @edison1105 Thank you very much as well for your energy for doing fixes so quick! |
ferferga
added a commit
to jellyfin/jellyfin-vue
that referenced
this pull request
Aug 29, 2024
Vue 3.5 fixed the issue where Suspense didn't inherit correctly the scope id. See vuejs/core/pull/10652
ferferga
added a commit
to jellyfin/jellyfin-vue
that referenced
this pull request
Aug 29, 2024
Vue 3.5 fixed the issue where Suspense didn't inherit correctly the scope id. See vuejs/core/pull/10652
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #5148