types(computed): allow computed getter and setter types to be unrelated#11472
Merged
yyx990803 merged 4 commits intovuejs:minorfrom Aug 5, 2024
Merged
types(computed): allow computed getter and setter types to be unrelated#11472yyx990803 merged 4 commits intovuejs:minorfrom
yyx990803 merged 4 commits intovuejs:minorfrom
Conversation
Size ReportBundles
Usages
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #7271
In certain cases, we would like the
computedproperty's getter and setter to have different types. This would provide added convenience in our usage, such as having the getter return a string while the setter accepts an object. In this PR, I have added a second generic parameter to thecomputedproperty to specify the type of the setter. With this enhancement, we can set different types for the getter and setter ofcomputedusing the following approach.Examples: