fix(reactive): markRaw function return the value directly when it has been marked#11864
Merged
yyx990803 merged 2 commits intovuejs:mainfrom Sep 10, 2024
forkandcook:fix-#11862
Merged
fix(reactive): markRaw function return the value directly when it has been marked#11864yyx990803 merged 2 commits intovuejs:mainfrom forkandcook:fix-#11862
yyx990803 merged 2 commits intovuejs:mainfrom
forkandcook:fix-#11862
Conversation
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Contributor
skirtles-code
left a comment
skirtles-code
left a comment
There was a problem hiding this comment.
Could you add a test case for this?
Currently there's a typo in the PR title, markRow.
packages/reactivity/src/reactive.ts
Outdated
| * @see {@link https://vuejs.org/api/reactivity-advanced.html#markraw} | ||
| */ | ||
| export function markRaw<T extends object>(value: T): Raw<T> { | ||
| if (hasOwn(value, ReactiveFlags.SKIP)) return value |
Contributor
There was a problem hiding this comment.
Perhaps merge this check into the if below, rather than duplicating the return value?
kovsu
changed the title
edison1105
added
need test
edison1105
approved these changes
Sep 9, 2024
edison1105
added
ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #11862