fix clippy warnings

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

Author: waynexia

benchmarks/src/bin/dfbench.rs

@@ -20,16 +20,16 @@ use datafusion::error::Result;
 
 use clap::{Parser, Subcommand};
 
-#[cfg(all(feature = "snmalloc", feature = "mimalloc"))]
+#[cfg(all(feature = "snmalloc", feature = "mimalloc", not(clippy)))]
 compile_error!(
     "feature \"snmalloc\" and feature \"mimalloc\" cannot be enabled at the same time"
 );
 
-#[cfg(feature = "snmalloc")]
+#[cfg(all(feature = "snmalloc", not(feature = "mimalloc")))]
 #[global_allocator]
 static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
 
-#[cfg(feature = "mimalloc")]
+#[cfg(all(feature = "mimalloc", not(feature = "snmalloc")))]
 #[global_allocator]
 static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc;
 

benchmarks/src/bin/imdb.rs

@@ -21,16 +21,16 @@ use clap::{Parser, Subcommand};
 use datafusion::error::Result;
 use datafusion_benchmarks::imdb;
 
-#[cfg(all(feature = "snmalloc", feature = "mimalloc"))]
+#[cfg(all(feature = "snmalloc", feature = "mimalloc", not(clippy)))]
 compile_error!(
     "feature \"snmalloc\" and feature \"mimalloc\" cannot be enabled at the same time"
 );
 
-#[cfg(feature = "snmalloc")]
+#[cfg(all(feature = "snmalloc", not(feature = "mimalloc")))]
 #[global_allocator]
 static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
 
-#[cfg(feature = "mimalloc")]
+#[cfg(all(feature = "mimalloc", not(feature = "snmalloc")))]
 #[global_allocator]
 static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc;
 

datafusion/common/src/error.rs

@@ -1243,7 +1243,6 @@ mod test {
     // To pass the test the environment variable RUST_BACKTRACE should be set to 1 to enforce backtrace
     #[cfg(feature = "backtrace")]
     #[test]
-    #[expect(clippy::unnecessary_literal_unwrap)]
     fn test_enabled_backtrace() {
         match std::env::var("RUST_BACKTRACE") {
             Ok(val) if val == "1" => {}

datafusion/common/src/hash_utils.rs

@@ -276,6 +276,7 @@ fn hash_array<T>(
 /// HAS_NULLS: do we have to check null in the inner loop
 /// HAS_BUFFERS: if true, array has external buffers; if false, all strings are inlined/ less then 12 bytes
 /// REHASH: if true, combining with existing hash, otherwise initializing
+#[cfg(not(feature = "force_hash_collisions"))]
 #[inline(never)]
 fn hash_string_view_array_inner<
     T: ByteViewType,

datafusion/optimizer/src/rewrite_set_comparison.rs

@@ -38,7 +38,7 @@ use datafusion_expr::utils::merge_schema;
 pub struct RewriteSetComparison;
 
 impl RewriteSetComparison {
-    #[allow(missing_docs)]
+    /// Create a new `RewriteSetComparison` optimizer rule.
     pub fn new() -> Self {
         Self
     }

datafusion/sql/src/expr/subquery.rs

@@ -178,10 +178,10 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
         let mut spans = Spans::new();
         if let SetExpr::Select(select) = subquery.body.as_ref() {
             for item in &select.projection {
-                if let SelectItem::ExprWithAlias { alias, .. } = item {
-                    if let Some(span) = Span::try_from_sqlparser_span(alias.span) {
-                        spans.add_span(span);
-                    }
+                if let SelectItem::ExprWithAlias { alias, .. } = item
+                    && let Some(span) = Span::try_from_sqlparser_span(alias.span)
+                {
+                    spans.add_span(span);
                 }
             }
         }