Skip to content

Commit 244b9e6

Browse files
committed
queries: queue is not named base_queue
1 parent 2c37cf6 commit 244b9e6

4 files changed

Lines changed: 24 additions & 23 deletions

File tree

integration_tests/suite/helpers/database.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -223,9 +223,9 @@ def insert_queue(self, **kwargs):
223223
if 'name' in kwargs:
224224
queue_kwargs['name'] = kwargs['name']
225225
queue_kwargs.setdefault('category', 'queue')
226-
queue = inserter.add_queue(**queue_kwargs)
227-
kwargs['_queue'] = queue
228-
kwargs.setdefault('name', queue.name)
226+
base_queue = inserter.add_base_queue(**queue_kwargs)
227+
kwargs['_queue'] = base_queue
228+
kwargs.setdefault('name', base_queue.name)
229229
queue_feature = inserter.add_queuefeatures(**kwargs)
230230
return {
231231
'id': queue_feature.id,

wazo_agid/handlers/groupfeatures.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -85,24 +85,25 @@ def _set_members(self) -> None:
8585
'mark_answered_elsewhere',
8686
'tenant_uuid',
8787
)
88-
queue_columns = ('musicclass', 'timeout', 'strategy', 'retry', 'maxlen')
88+
base_queue_columns = ('musicclass', 'timeout', 'strategy', 'retry', 'maxlen')
8989
extensions_columns = ('exten', 'context')
9090
columns = [sanitize_column(f"groupfeatures.{c}") for c in groupfeatures_columns]
9191
columns += [
92-
sanitize_aliased_column(f"queue.{c}", f"queue_{c}") for c in queue_columns
92+
sanitize_aliased_column(f"base_queue.{c}", f"base_queue_{c}")
93+
for c in base_queue_columns
9394
]
9495
columns += [sanitize_column(f"extensions.{c}") for c in extensions_columns]
9596

9697
query = SQL(
9798
"SELECT {columns} FROM groupfeatures "
98-
"INNER JOIN queue "
99-
"ON groupfeatures.name = queue.name "
99+
"INNER JOIN base_queue "
100+
"ON groupfeatures.name = base_queue.name "
100101
"LEFT JOIN extensions "
101102
"ON groupfeatures.id::text = extensions.typeval "
102103
"AND extensions.type = 'group' "
103104
"WHERE groupfeatures.id = %s "
104-
"AND queue.category = 'group' "
105-
"AND queue.commented = 0"
105+
"AND base_queue.category = 'group' "
106+
"AND base_queue.commented = 0"
106107
)
107108
self._cursor.execute(query.format(columns=SQL(", ").join(columns)), (self._id,))
108109
res: DictRow = self._cursor.fetchone()
@@ -121,13 +122,13 @@ def _set_members(self) -> None:
121122
self._write_calling = res['write_calling']
122123
self._ignore_forward = res['ignore_forward']
123124
self._preprocess_subroutine = res['preprocess_subroutine']
124-
self._musicclass = res['queue_musicclass']
125+
self._musicclass = res['base_queue_musicclass']
125126
self._mark_answered_elsewhere = res['mark_answered_elsewhere']
126127
self._tenant_uuid = res['tenant_uuid']
127-
self._user_timeout = res['queue_timeout']
128-
self._group_strategy = res['queue_strategy']
129-
self._group_retry_delay = res['queue_retry']
130-
self._max_calls = res['queue_maxlen']
128+
self._user_timeout = res['base_queue_timeout']
129+
self._group_strategy = res['base_queue_strategy']
130+
self._group_retry_delay = res['base_queue_retry']
131+
self._max_calls = res['base_queue_maxlen']
131132

132133
def _set_vars(self) -> None:
133134
self._agi.set_variable(dv.REAL_NUMBER, self._exten)

wazo_agid/modules/user_set_call_rights.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,14 @@ def _user_set_call_rights(
7878
"SELECT groupfeatures.id FROM groupfeatures "
7979
"INNER JOIN queuemember "
8080
"ON groupfeatures.name = queuemember.queue_name "
81-
"INNER JOIN queue "
82-
"ON queue.name = queuemember.queue_name "
81+
"INNER JOIN base_queue "
82+
"ON base_queue.name = queuemember.queue_name "
8383
"WHERE queuemember.userid = %s "
8484
"AND queuemember.usertype = 'user' "
8585
"AND queuemember.category = 'group' "
8686
"AND queuemember.commented = 0 "
87-
"AND queue.category = 'group' "
88-
"AND queue.commented = 0",
87+
"AND base_queue.category = 'group' "
88+
"AND base_queue.commented = 0",
8989
(user.id,),
9090
)
9191
group_feature_res: list[DictRow] = cursor.fetchall()

wazo_agid/objects.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ def __init__(self, agi: FastAGI, cursor: DictCursor, queue_id: int):
513513
'mark_answered_elsewhere',
514514
]
515515
queuefeatures_columns = ["queuefeatures." + c for c in queuefeatures_columns]
516-
queue_columns = ['queue.wrapuptime', 'queue.musicclass']
516+
queue_columns = ['base_queue.wrapuptime', 'base_queue.musicclass']
517517

518518
columns = queuefeatures_columns + queue_columns
519519

@@ -522,11 +522,11 @@ def __init__(self, agi: FastAGI, cursor: DictCursor, queue_id: int):
522522

523523
query = SQL(
524524
"SELECT {columns} FROM queuefeatures "
525-
"INNER JOIN queue "
526-
"ON queuefeatures.name = queue.name "
525+
"INNER JOIN base_queue "
526+
"ON queuefeatures.name = base_queue.name "
527527
"WHERE queuefeatures.id = %s "
528-
"AND queue.commented = 0 "
529-
"AND queue.category = 'queue'"
528+
"AND base_queue.commented = 0 "
529+
"AND base_queue.category = 'queue'"
530530
)
531531
cursor.execute(
532532
query.format(columns=join_column_names(columns)),

0 commit comments

Comments
 (0)