Fix bug when checking agent configuration in logcollector#1225
Merged
Conversation
crolopez
force-pushed
the
fix-verify-logcollector
branch
from
fea599b to
93000a0
Compare
vikman90
requested changes
Sep 5, 2018
| } | ||
| while (g.gl_pathv[glob_offset] != NULL) { | ||
| if (current_files >= maximum_files) { | ||
| if (maximum_files && current_files >= maximum_files) { |
Member
There was a problem hiding this comment.
Is this check necessary? maximum_files should never be 0 in Logcollector, and it if was, it would be an error.
vikman90
approved these changes
Sep 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the bug that didn't allow to check if logcollector configurations were valid. These checks are done with the verify-agent-conf tool and when the agent loads a remote configuration.
Although it does not check the logcollector configuration of the agents, they still can load the remote configuration, showing the following warning message:
2018/09/04 16:15:05 ossec-agentd: WARNING: (1960): File limit has been reached (0). Please reduce the number of files or increase "logcollector.max_files".