feat: allow data to be prepended via options.prependData#327
Merged
alexander-akait merged 2 commits intomasterfrom Mar 16, 2020
Merged
feat: allow data to be prepended via options.prependData#327alexander-akait merged 2 commits intomasterfrom
options.prependData#327alexander-akait merged 2 commits intomasterfrom
Conversation
ryanclark
force-pushed
the
prepend-data-option
branch
from
db6fbdd to
c54a57f
Compare
ryanclark
commented
Mar 16, 2020
| const lessOptions = getLessOptions(this, options, source); | ||
|
|
||
| processResult(this, render(source, lessOptions), callback); | ||
| processResult(this, render(lessOptions.data, lessOptions), callback); |
Contributor
Author
There was a problem hiding this comment.
I was considering having getLessOptions return an object of {lessOptions, data} so we wouldn't pollute the lessOptions with data - can change if needed
README.md
Outdated
| const { resourcePath, rootContext } = loaderContext; | ||
| const relativePath = path.relative(rootContext, resourcePath); | ||
|
|
||
| if (relativePath === 'styles/foo.scss') { |
Contributor
Author
There was a problem hiding this comment.
Oops, good catch, fixed
alexander-akait
approved these changes
Mar 16, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Add the
prependDataoption thatsass-loaderoffers