Skip to content

fix: support esm format for configurations#2381

Merged
alexander-akait merged 18 commits intomasterfrom
issue-1622
Feb 1, 2021
Merged

fix: support esm format for configurations#2381
alexander-akait merged 18 commits intomasterfrom
issue-1622

Conversation

@alexander-akait
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

yes

If relevant, did you update the documentation?

Yep

Summary

fixes #1622

Does this PR introduce a breaking change?

No

Other information

No

@alexander-akait
Copy link
Copy Markdown
Member Author

Something has global side effects, it breaks our tests...

@alexander-akait
Copy link
Copy Markdown
Member Author

I hate our tests for init and other generators, it is unstable on 100%, we need fully rewrite them

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2021

Codecov Report

Merging #2381 (0fa244b) into master (9d6dbda) will increase coverage by 0.47%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2381      +/-   ##
==========================================
+ Coverage   71.26%   71.74%   +0.47%     
==========================================
  Files          46       47       +1     
  Lines        2158     2173      +15     
  Branches      570      573       +3     
==========================================
+ Hits         1538     1559      +21     
+ Misses        620      614       -6     
Impacted Files Coverage Δ
packages/webpack-cli/bin/cli.js 50.00% <75.00%> (+5.55%) ⬆️
...ges/webpack-cli/lib/utils/dynamic-import-loader.js 83.33% <83.33%> (ø)
packages/webpack-cli/lib/bootstrap.js 100.00% <100.00%> (ø)
packages/webpack-cli/lib/utils/index.js 84.00% <100.00%> (+1.39%) ⬆️
packages/webpack-cli/lib/webpack-cli.js 91.88% <100.00%> (+0.80%) ⬆️
...kages/generators/src/utils/modify-config-helper.ts 57.14% <0.00%> (-0.76%) ⬇️
packages/init/src/index.ts 88.88% <0.00%> (ø)
packages/generators/src/utils/scaffold.ts 77.55% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6dbda...0fa244b. Read the comment docs.

@alexander-akait
Copy link
Copy Markdown
Member Author

Found the problem, somebody install @babel/core in out tests so, recoil try to use it, also we need test for this I think

@alexander-akait
Copy link
Copy Markdown
Member Author

alexander-akait commented Jan 31, 2021

I hate nyc, it wrap require and can't provide option to disable it for specific lines, so it return invalid cde and I can't find how we can test it

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Error [ERR_REQUIRE_ESM]: Must use import to load ES Module

2 participants