fix: support esm format for configurations#2381
Merged
alexander-akait merged 18 commits intomasterfrom Feb 1, 2021
Merged
Conversation
865ac2e to
c4a50db
Compare
Member
Author
|
Something has global side effects, it breaks our tests... |
Member
Author
|
I hate our tests for |
Codecov Report
@@ Coverage Diff @@
## master #2381 +/- ##
==========================================
+ Coverage 71.26% 71.74% +0.47%
==========================================
Files 46 47 +1
Lines 2158 2173 +15
Branches 570 573 +3
==========================================
+ Hits 1538 1559 +21
+ Misses 620 614 -6
Continue to review full report at Codecov.
|
c653648 to
0d92835
Compare
Member
Author
|
Found the problem, somebody install |
Member
Author
|
I hate |
8dbd336 to
b19d015
Compare
This was referenced Mar 12, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
Yep
Summary
fixes #1622
Does this PR introduce a breaking change?
No
Other information
No