test: default loader name and plugin name

[rishabh3112]

What kind of change does this PR introduce?
feat

Did you add tests for your changes?
Not needed, already present

If relevant, did you update the documentation?
No

Summary
Enforced use of process.cwd() as default output-path

Does this PR introduce a breaking change?
No

Other information
Part of Roadmap

[codecov]

Codecov Report

Merging #2392 (dd95a1d) into master (7bd747a) will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2392      +/-   ##
==========================================
+ Coverage   71.27%   71.74%   +0.46%     
==========================================
  Files          46       47       +1     
  Lines        2155     2173      +18     
  Branches      568      573       +5     
==========================================
+ Hits         1536     1559      +23     
+ Misses        619      614       -5     

Impacted Files	Coverage Δ
packages/webpack-cli/lib/bootstrap.js	100.00% <0.00%> (ø)
...ges/webpack-cli/lib/utils/dynamic-import-loader.js	83.33% <0.00%> (ø)
packages/webpack-cli/lib/webpack-cli.js	91.88% <0.00%> (+0.80%)	⬆️
packages/webpack-cli/lib/utils/index.js	84.00% <0.00%> (+1.39%)	⬆️
packages/webpack-cli/bin/cli.js	50.00% <0.00%> (+5.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd747a...dd95a1d. Read the comment docs.

[jamesgeorge007]

yeoman-environment handles it already.
https://github.com/yeoman/environment/blob/main/lib/environment.js#L223

[alexander-akait]

@jamesgeorge007 Good catch, maybe we just need add test(s)

[rishabh3112]

Good catch, maybe we just need add test(s)

Tests are already present. Why this was included in roadmap?

[alexander-akait]

Can you provide link on tests? Maybe I something missed

[rishabh3112]

Can you provide link on tests? Maybe I something missed

output-path is not provided in all the tests below:

https://github.com/webpack/webpack-cli/blob/master/test/loader/loader.test.js#L22
https://github.com/webpack/webpack-cli/blob/master/test/loader/loader.test.js#L29

https://github.com/webpack/webpack-cli/blob/master/test/plugin/plugin.test.js#L22
https://github.com/webpack/webpack-cli/blob/master/test/plugin/plugin.test.js#L29

[alexander-akait]

No tests, https://github.com/webpack/webpack-cli/blob/master/test/loader/loader.test.js#L22 is not enough for testing, it is stupid test on the question, it should be fully test with checking on files https://github.com/webpack/webpack-cli/blob/master/test/loader/loader.test.js#L43

[rishabh3112]

Line 29 has it.

[alexander-akait]

Line 29 pass loaderName - let { stdout } = await runPromptWithAnswers(__dirname, ['loader'], [${loaderName}${ENTER}]);, we should have test without passing loader name (full test)

[rishabh3112]

Loader name is not being passed as output-path, it is an answer to an inquirer question asked by generator.

Nevertheless will add test for default loader name as well.

[alexander-akait]

Thanks