Consistent prefix in logError/logWarning

Author: webpro

packages/knip/src/cli.ts

@@ -111,7 +111,7 @@ const main = async () => {
     process.exitCode = 2;
     if (!args.debug && error instanceof Error && isKnownError(error)) {
       const knownErrors = getKnownErrors(error);
-      for (const knownError of knownErrors) logError('ERROR', knownError.message);
+      for (const knownError of knownErrors) logError(knownError.message);
       if (hasErrorCause(knownErrors[0])) {
         console.error('Reason:', knownErrors[0].cause.message);
         if (isModuleNotFoundError(knownErrors[0].cause))

packages/knip/src/util/create-options.ts

@@ -66,13 +66,13 @@ export const createOptions = async (options: CreateOptions) => {
       const invalid = value.filter((v: string) => !validIssueTypes.has(v));
       if (invalid.length > 0) {
         loadedConfig[key] = value.filter((v: string) => validIssueTypes.has(v));
-        for (const name of invalid) logWarning('WARNING', `Ignored unknown issue type "${name}" in ${key}`);
+        for (const name of invalid) logWarning(`Ignored unknown issue type "${name}" in ${key}`);
       }
     } else if (typeof value === 'object') {
       for (const name in value) {
         if (!validIssueTypes.has(name)) {
           delete value[name];
-          logWarning('WARNING', `Ignored unknown issue type "${name}" in ${key}`);
+          logWarning(`Ignored unknown issue type "${name}" in ${key}`);
         }
       }
     }

packages/knip/src/util/log.ts

@@ -1,10 +1,10 @@
 /* oxlint-disable no-console */
 import st from './colors.ts';
 
-export const logWarning = (prefix: string, message: string) => {
-  console.warn(`${st.yellow(prefix)}: ${message}`);
+export const logWarning = (message: string) => {
+  console.warn(`${st.yellow('WARNING')}: ${message}`);
 };
 
-export const logError = (prefix: string, message: string) => {
-  console.error(`${st.red(prefix)}: ${message}`);
+export const logError = (message: string) => {
+  console.error(`${st.red('ERROR')}: ${message}`);
 };

packages/knip/src/util/map-workspaces.ts

@@ -41,7 +41,7 @@ export default async function mapWorkspaces(cwd: string, workspaces: string[]):
       if (error instanceof Error && 'code' in error && error.code === 'ENOENT') {
         debugLog('*', `Unable to load package.json for ${name}`);
       } else if (error instanceof SyntaxError) {
-        logWarning('WARNING', `Skipping workspace ${name}: invalid JSON in ${manifestPath} (${error.message})`);
+        logWarning(`Skipping workspace ${name}: invalid JSON in ${manifestPath} (${error.message})`);
       } else throw error;
     }
   }