Support absolute file paths in react-router routes (#1659)

Author: mpalmer685

packages/knip/fixtures/plugins/react-router-with-absolute-paths/app/root.tsx

@@ -0,0 +1,12 @@
+import { fileURLToPath } from 'node:url';
+import { resolve, dirname } from 'node:path';
+
+const dir = dirname(fileURLToPath(import.meta.url));
+
+export default [
+  { file: resolve(dir, 'routes/home.tsx'), index: true },
+  {
+    file: resolve(dir, 'routes/layout.tsx'),
+    children: [{ file: resolve(dir, 'routes/child.tsx') }],
+  },
+];

packages/knip/fixtures/plugins/react-router-with-absolute-paths/app/routes.ts

@@ -0,0 +1,10 @@
+{
+  "name": "@plugins/react-router-with-absolute-paths",
+  "dependencies": {
+    "@react-router/node": "*",
+    "isbot": "*"
+  },
+  "devDependencies": {
+    "@react-router/dev": "*"
+  }
+}

packages/knip/fixtures/plugins/react-router-with-absolute-paths/app/routes/child.tsx

@@ -0,0 +1,7 @@
+import type { Config } from '@react-router/dev/config';
+
+export default {
+  // Config options...
+  // Server-side render by default, to enable SPA mode set this to `false`
+  ssr: true,
+} satisfies Config;

packages/knip/fixtures/plugins/react-router-with-absolute-paths/app/routes/home.tsx

@@ -41,7 +41,7 @@ const resolveConfig: ResolveConfig<PluginConfig> = async (localConfig, options)
   }
 
   const mapRoute = (route: RouteConfigEntry): string[] => {
-    return [join(appDir, route.file), ...(route.children ? route.children.flatMap(mapRoute) : [])];
+    return [toAbsolute(route.file, appDir), ...(route.children ? route.children.flatMap(mapRoute) : [])];
   };
 
   const routes = routeConfig

packages/knip/fixtures/plugins/react-router-with-absolute-paths/app/routes/layout.tsx

@@ -23,6 +23,18 @@ test('Find dependencies with the react-router plugin', async () => {
   });
 });
 
+test('Find dependencies with the react-router plugin [with absolute paths]', async () => {
+  const cwd = resolve('fixtures/plugins/react-router-with-absolute-paths');
+  const options = await createOptions({ cwd });
+  const { counters } = await main(options);
+
+  assert.deepEqual(counters, {
+    ...baseCounters,
+    processed: 6,
+    total: 6,
+  });
+});
+
 test('Find dependencies with the react-router plugin [with custom server entry]', async () => {
   const cwd = resolve('fixtures/plugins/react-router-with-server-entry');
   const options = await createOptions({ cwd });