Skip workspace with invalid JSON manifest

Author: webpro

packages/knip/fixtures/workspaces-malformed-manifest/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "@fixtures/workspaces-malformed-manifest",
+  "private": true,
+  "workspaces": ["packages/*"]
+}

packages/knip/fixtures/workspaces-malformed-manifest/packages/broken/index.ts

@@ -0,0 +1 @@
+export const b = 2;

packages/knip/fixtures/workspaces-malformed-manifest/packages/broken/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "@fixtures/workspaces-malformed-manifest__broken",
+  "main": "./index.ts",
+}

packages/knip/fixtures/workspaces-malformed-manifest/packages/good/index.ts

@@ -0,0 +1 @@
+export const a = 1;

packages/knip/fixtures/workspaces-malformed-manifest/packages/good/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "@fixtures/workspaces-malformed-manifest__good",
+  "main": "./index.ts"
+}

packages/knip/src/util/map-workspaces.ts

@@ -2,7 +2,9 @@ import { readFile } from 'node:fs/promises';
 import { glob } from 'tinyglobby';
 import type { PackageJson, WorkspacePackage } from '../types/package-json.ts';
 import { partition } from './array.ts';
+import { debugLog } from './debug.ts';
 import { ConfigurationError } from './errors.ts';
+import { logWarning } from './log.ts';
 import { getPackageName } from './package-name.ts';
 import { join } from './path.ts';
 
@@ -36,9 +38,11 @@ export default async function mapWorkspaces(cwd: string, workspaces: string[]):
       if (pkgName) wsPkgNames.add(pkgName);
       else throw new ConfigurationError(`Missing package name in ${manifestPath}`);
     } catch (error) {
-      // @ts-expect-error
-      if (error?.code === 'ENOENT') debugLog('*', `Unable to load package.json for ${name}`);
-      else throw error;
+      if (error instanceof Error && 'code' in error && error.code === 'ENOENT') {
+        debugLog('*', `Unable to load package.json for ${name}`);
+      } else if (error instanceof SyntaxError) {
+        logWarning('WARNING', `Skipping workspace ${name}: invalid JSON in ${manifestPath} (${error.message})`);
+      } else throw error;
     }
   }
 

packages/knip/test/workspaces-malformed-manifest.test.ts

@@ -0,0 +1,12 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import { main } from '../src/index.ts';
+import { createOptions } from './helpers/create-options.ts';
+import { resolve } from './helpers/resolve.ts';
+
+const cwd = resolve('fixtures/workspaces-malformed-manifest');
+
+test('Skip workspace with invalid JSON in package.json (warn, continue)', async () => {
+  const options = await createOptions({ cwd });
+  await assert.doesNotReject(main(options));
+});