Improve performance, but only slightly

Author: webpro

packages/knip/src/reporters/util/util.ts

@@ -51,12 +51,14 @@ const sortByPos = (a: Issue, b: Issue) => {
 const highlightSymbol =
   (issue: Issue) =>
   (_: unknown): string => {
-    if (issue.specifier && issue.specifier !== issue.symbol && issue.specifier.includes(issue.symbol)) {
-      const parts = issue.specifier.split(issue.symbol);
-      const rest = parts.slice(1).join('');
-      return [dim(parts[0]), bright(issue.symbol), dim(rest)].join('');
+    const { specifier, symbol } = issue;
+    if (specifier && specifier !== symbol) {
+      const idx = specifier.indexOf(symbol);
+      if (idx !== -1) {
+        return `${dim(specifier.slice(0, idx))}${bright(symbol)}${dim(specifier.slice(idx + symbol.length))}`;
+      }
     }
-    return issue.symbol;
+    return symbol;
   };
 
 export const getTableForType = (

packages/knip/src/util/glob-core.ts

@@ -8,7 +8,7 @@ import { debugLogObject } from './debug.ts';
 import { isDirectory, isFile } from './fs.ts';
 import { timerify } from './Performance.ts';
 import { expandIgnorePatterns, parseAndConvertGitignorePatterns } from './parse-and-convert-gitignores.ts';
-import { basename, dirname, join, relative, toPosix } from './path.ts';
+import { dirname, join, relative, toPosix } from './path.ts';
 
 type Options = { gitignore: boolean; cwd: string };
 
@@ -167,15 +167,16 @@ export const findAndParseGitignores = async (cwd: string, workspaceDirs?: Set<st
     }
   }
 
+  const cwdPrefixLen = cwd.length + 1;
   const walkGitignores = async () => {
     await new fdir()
       .withFullPaths()
       .exclude((_dirName: string, dirPath: string) => {
-        const absPath = toPosix(dirPath.endsWith('/') ? dirPath.slice(0, -1) : dirPath);
-        return (isRelevantDir && !isRelevantDir(absPath)) || getMatcher()(relative(cwd, absPath));
+        const absPath = toPosix(dirPath.slice(0, -1));
+        return (isRelevantDir && !isRelevantDir(absPath)) || getMatcher()(absPath.slice(cwdPrefixLen));
       })
       .filter((filePath: string, isDir: boolean) => {
-        if (isDir || basename(filePath) !== '.gitignore') return false;
+        if (isDir || !filePath.endsWith('/.gitignore')) return false;
         addFile(filePath);
         return true;
       })