fix: hash faster than callback#186
Merged
ThaUnknown merged 1 commit intowebtorrent:masterfrom Nov 10, 2022
Merged
Conversation
DiegoRBaquero
approved these changes
Nov 10, 2022
webtorrent-bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
## [5.0.9](v5.0.8...v5.0.9) (2022-11-10) ### Bug Fixes * hash faster than callback ([#186](#186)) ([298f356](298f356))
|
🎉 This PR is included in version 5.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
fixes an issue where tha sha1 sync hash could be faster than the resolve() callback promise causing an indefinite wait, oops!