Skip to content

Commit 4dacdb9

Browse files
committed
fix: PR feedback
1 parent f0f7b22 commit 4dacdb9

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

libraries/core/src/conversation/conversationService/conversationService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -999,7 +999,7 @@ export class ConversationService extends TypedEventEmitter<Events> {
999999
} catch (error: unknown) {
10001000
// For unmapped or unrecoverable errors, avoid surfacing exceptions from event handling
10011001
// and instead log and return null so the event processing queue can continue safely.
1002-
this.logger.error('Failed to handle MLS message-add event after recovery; returning null', {error});
1002+
this.logger.error('Failed to handle MLS message-add event after recovery; returning null', {error, event});
10031003
return null;
10041004
}
10051005
}
@@ -1040,7 +1040,7 @@ export class ConversationService extends TypedEventEmitter<Events> {
10401040
* Always resolves to null; the effects are applied to local state.
10411041
*/
10421042
private async handleMLSWelcomeMessageEvent(event: ConversationMLSWelcomeEvent): Promise<HandledEventPayload | null> {
1043-
this.logger.info('Handling MLS welcome message event (orchestrated)');
1043+
this.logger.info('Handling MLS welcome message event (orchestrated)', {event});
10441044
await this.MLSRecoveryOrchestrator.execute({
10451045
context: {
10461046
operationName: OperationName.handleWelcome,

libraries/core/src/notification/notificationService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ export class NotificationService extends TypedEventEmitter<Events> {
212212
source: NotificationSource,
213213
): AsyncGenerator<HandledEventPayload> {
214214
for (const event of notification.payload) {
215-
this.logger.debug(`Handling event of type "${event.type}"`);
215+
this.logger.debug(`Handling event of type "${event.type}"`, event);
216216
let lastEventDate: Date | undefined = undefined;
217217
try {
218218
lastEventDate = await this.database.getLastEventDate();

0 commit comments

Comments
 (0)