Skip to content

Commit 0980312

Browse files
alextimNate Moore
andauthored
unused dependency 'sitemap', 'filter' option should return boolean (#3563)
* refactor: @astrojs/sitemap does't use 'sitemap' pkg * refactor: 'filter' option should return boolean instead of string * fix: forgotten `pnpm install` * chore: add changeset Co-authored-by: Nate Moore <nate@skypack.dev>
1 parent 72587ec commit 0980312

4 files changed

Lines changed: 6 additions & 22 deletions

File tree

.changeset/nice-zebras-unite.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@astrojs/sitemap': patch
3+
---
4+
5+
Remove unused dependency

packages/integrations/sitemap/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
"dev": "astro-scripts dev \"src/**/*.ts\""
2828
},
2929
"dependencies": {
30-
"sitemap": "^7.1.1"
3130
},
3231
"devDependencies": {
3332
"astro": "workspace:*",

packages/integrations/sitemap/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ type SitemapOptions =
1515
* filter: (page) => page !== 'http://example.com/secret-page'
1616
* ```
1717
*/
18-
filter?(page: string): string;
18+
filter?(page: string): boolean;
1919

2020
/**
2121
* If you have any URL, not rendered by Astro, that you want to include in your sitemap,

pnpm-lock.yaml

Lines changed: 0 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)