Skip to content

Commit 34df955

Browse files
authored
chore: inline dlv dependency (#16259)
* chore: inline dlv dependency * format * Create three-kids-camp.md * fix: use `for...of`
1 parent 0d278ac commit 34df955

7 files changed

Lines changed: 15 additions & 11 deletions

File tree

.changeset/three-kids-camp.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
astro: patch
3+
---
4+
5+
Removed `dlv` dependency

packages/astro/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@
138138
"cookie": "^1.1.1",
139139
"devalue": "^5.6.3",
140140
"diff": "^8.0.3",
141-
"dlv": "^1.1.3",
142141
"dset": "^3.1.4",
143142
"es-module-lexer": "^2.0.0",
144143
"esbuild": "^0.27.3",
@@ -186,7 +185,6 @@
186185
"@astrojs/compiler-rs": "^0.1.6",
187186
"@playwright/test": "1.58.2",
188187
"@types/aria-query": "^5.0.4",
189-
"@types/dlv": "^1.1.5",
190188
"@types/hast": "^3.0.4",
191189
"@types/html-escaper": "3.0.4",
192190
"@types/http-cache-semantics": "^4.2.0",

packages/astro/src/cli/preferences/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import { fileURLToPath } from 'node:url';
22
import { formatWithOptions } from 'node:util';
3-
import dlv from 'dlv';
43
import { flattie } from 'flattie';
54
import colors from 'piccolore';
65
import { resolveConfig } from '../../core/config/config.js';
76
import { createSettings } from '../../core/config/settings.js';
87
import { collectErrorMetadata } from '../../core/errors/dev/utils.js';
98
import * as msg from '../../core/messages/runtime.js';
109
import { DEFAULT_PREFERENCES } from '../../preferences/defaults.js';
10+
import dlv from '../../preferences/dlv.js';
1111
import { coerce, isValidKey, type PreferenceKey } from '../../preferences/index.js';
1212
import type { AstroSettings } from '../../types/astro.js';
1313
import { createLoggerFromFlags, type Flags, flagsToAstroInlineConfig } from '../flags.js';
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
export default function dlv(obj: Record<string, unknown>, key: string): any {
2+
for (const k of key.split('.')) {
3+
// @ts-expect-error: Type 'unknown' is not assignable to type 'Record<string, unknown>'.
4+
obj = obj?.[k];
5+
}
6+
return obj;
7+
}

packages/astro/src/preferences/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import os from 'node:os';
22
import path from 'node:path';
33
import process from 'node:process';
44
import { fileURLToPath } from 'node:url';
5-
import dget from 'dlv';
65
import { DEFAULT_PREFERENCES, type Preferences, type PublicPreferences } from './defaults.js';
6+
import dget from './dlv.js';
77
import { PreferenceStore } from './store.js';
88

99
type DotKeys<T> = T extends object

packages/astro/src/preferences/store.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import fs from 'node:fs';
22
import path from 'node:path';
3-
import dget from 'dlv';
43
import { dset } from 'dset';
54
import { SETTINGS_FILE } from './constants.js';
5+
import dget from './dlv.js';
66

77
export class PreferenceStore {
88
private dir: string;

pnpm-lock.yaml

Lines changed: 0 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)