Add the output option (#4015)

* Start of work on astroConfig.mode === 'server'

* Add tests and more

* adapter -> deploy in some places

* Add fallback for `adapter` config

* Update more tests

* Update image tests

* Fix clientAddress test

* Updates based on PR review

* Add a changeset

* Update integrations tests + readme

* Oops

* Remove old option

* Rename `mode` to `output`

* Update Node adapter test

* Update test

* fred pass

* fred pass

* fred pass

* fix test

Co-authored-by: Fred K. Schott <fkschott@gmail.com>

Author: matthewp

packages/integrations/netlify/README.md

@@ -37,6 +37,7 @@ import { defineConfig } from 'astro/config';
 import netlify from '@astrojs/netlify/functions';
 
 export default defineConfig({
+  output: 'server',
 	adapter: netlify(),
 });
 ```
@@ -51,6 +52,7 @@ import { defineConfig } from 'astro/config';
 + import netlify from '@astrojs/netlify/edge-functions';
 
 export default defineConfig({
+  output: 'server',
 	adapter: netlify(),
 });
 ```
@@ -83,6 +85,7 @@ import { defineConfig } from 'astro/config';
 import netlify from '@astrojs/netlify/functions';
 
 export default defineConfig({
+  output: 'server',
   adapter: netlify({
     dist: new URL('./dist/', import.meta.url)
   })

packages/integrations/netlify/src/integration-edge-functions.ts

@@ -135,6 +135,11 @@ export function netlifyEdgeFunctions({ dist }: NetlifyEdgeFunctionsOptions = {})
 			'astro:config:done': ({ config, setAdapter }) => {
 				setAdapter(getAdapter());
 				_config = config;
+
+				if(config.output === 'static') {
+					console.warn(`[@astrojs/netlify] \`output: "server"\` is required to use this adapter.`);
+					console.warn(`[@astrojs/netlify] Otherwise, this adapter is not required to deploy a static site to Netlify.`);
+		}
 			},
 			'astro:build:start': async ({ buildConfig }) => {
 				_buildConfig = buildConfig;

packages/integrations/netlify/src/integration-functions.ts

@@ -35,6 +35,11 @@ function netlifyFunctions({
 			'astro:config:done': ({ config, setAdapter }) => {
 				setAdapter(getAdapter({ binaryMediaTypes }));
 				_config = config;
+
+				if(config.output === 'static') {
+					console.warn(`[@astrojs/netlify] \`output: "server"\` is required to use this adapter.`);
+					console.warn(`[@astrojs/netlify] Otherwise, this adapter is not required to deploy a static site to Netlify.`);
+				}
 			},
 			'astro:build:start': async ({ buildConfig }) => {
 				entryFile = buildConfig.serverEntry.replace(/\.m?js/, '');

packages/integrations/netlify/test/edge-functions/fixtures/dynimport/astro.config.mjs

@@ -5,7 +5,5 @@ export default defineConfig({
 	adapter: netlifyEdgeFunctions({
 		dist: new URL('./dist/', import.meta.url),
 	}),
-	experimental: {
-		ssr: true
-	}
+	output: 'server',
 })

packages/integrations/netlify/test/edge-functions/fixtures/edge-basic/astro.config.mjs

@@ -7,7 +7,5 @@ export default defineConfig({
 		dist: new URL('./dist/', import.meta.url),
 	}),
 	integrations: [react()],
-	experimental: {
-		ssr: true
-	}
+	output: 'server',
 })

packages/integrations/netlify/test/edge-functions/fixtures/root-dynamic/astro.config.mjs

@@ -5,7 +5,5 @@ export default defineConfig({
 	adapter: netlifyEdgeFunctions({
 		dist: new URL('./dist/', import.meta.url),
 	}),
-	experimental: {
-		ssr: true
-	}
+	output: 'server',
 })

packages/integrations/netlify/test/functions/base64-response.test.js

@@ -9,9 +9,7 @@ describe('Base64 Responses', () => {
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/base64-response/', import.meta.url).toString(),
-			experimental: {
-				ssr: true,
-			},
+			output: 'server',
 			adapter: netlifyAdapter({
 				dist: new URL('./fixtures/base64-response/dist/', import.meta.url),
 				binaryMediaTypes: ['font/otf'],

packages/integrations/netlify/test/functions/cookies.test.js

@@ -11,9 +11,7 @@ describe('Cookies', () => {
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/cookies/', import.meta.url).toString(),
-			experimental: {
-				ssr: true,
-			},
+			output: 'server',
 			adapter: netlifyAdapter({
 				dist: new URL('./fixtures/cookies/dist/', import.meta.url),
 			}),

packages/integrations/netlify/test/functions/dynamic-route.test.js

@@ -9,9 +9,7 @@ describe('Dynamic pages', () => {
 	before(async () => {
 		fixture = await loadFixture({
 			root: new URL('./fixtures/dynamic-route/', import.meta.url).toString(),
-			experimental: {
-				ssr: true,
-			},
+			output: 'server',
 			adapter: netlifyAdapter({
 				dist: new URL('./fixtures/dynamic-route/dist/', import.meta.url),
 			}),