test: port 16 routing unit tests to TypeScript (#16266)

Author: barry3406

…o/test/units/routing/api-context.test.js …o/test/units/routing/api-context.test.tspackages/astro/test/units/routing/api-context.test.js renamed to packages/astro/test/units/routing/api-context.test.ts packages/astro/test/units/routing/api-context.test.js renamed to packages/astro/test/units/routing/api-context.test.ts

@@ -8,6 +8,7 @@ describe('createAPIContext', () => {
 
 		const context = createContext({
 			request,
+			defaultLocale: '',
 			clientAddress: '192.0.2.43',
 		});
 
@@ -19,11 +20,12 @@ describe('createAPIContext', () => {
 
 		const context = createContext({
 			request,
+			defaultLocale: '',
 		});
 
 		assert.throws(
 			() => context.clientAddress,
-			(err) => {
+			(err: Error) => {
 				assert.equal(err.name, 'StaticClientAddressNotAvailable');
 				return true;
 			},
@@ -39,12 +41,13 @@ describe('createAPIContext', () => {
 
 		const context = createContext({
 			request,
+			defaultLocale: '',
 		});
 
 		// Should throw instead of reading from the header
 		assert.throws(
 			() => context.clientAddress,
-			(err) => {
+			(err: Error) => {
 				assert.equal(err.name, 'StaticClientAddressNotAvailable');
 				return true;
 			},
@@ -56,6 +59,7 @@ describe('createAPIContext', () => {
 
 		const context = createContext({
 			request,
+			defaultLocale: '',
 			locals: {
 				foo: 'bar',
 			},

…o/test/units/routing/dev-routing.test.js …o/test/units/routing/dev-routing.test.tspackages/astro/test/units/routing/dev-routing.test.js renamed to packages/astro/test/units/routing/dev-routing.test.ts packages/astro/test/units/routing/dev-routing.test.js renamed to packages/astro/test/units/routing/dev-routing.test.ts

@@ -1,10 +1,18 @@
-import * as assert from 'node:assert/strict';
+import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
-
+import type { AstroConfig } from '../../../dist/types/public/config.js';
+import type { RoutePart } from '../../../dist/types/public/internal.js';
 import { getRouteGenerator } from '../../../dist/core/routing/generator.js';
 
+interface TestCase {
+	routeData: RoutePart[][];
+	trailingSlash: AstroConfig['trailingSlash'];
+	params: Record<string, string | number>;
+	path: string;
+}
+
 describe('routing - generator', () => {
-	[
+	const cases: TestCase[] = [
 		{
 			routeData: [],
 			trailingSlash: 'never',
@@ -135,7 +143,9 @@ describe('routing - generator', () => {
 			params: { page: 1 },
 			path: '/fix/1',
 		},
-	].forEach(({ routeData, trailingSlash, params, path }) => {
+	];
+
+	cases.forEach(({ routeData, trailingSlash, params, path }) => {
 		it(`generates ${path}`, () => {
 			const generator = getRouteGenerator(routeData, trailingSlash);
 			assert.equal(generator(params), path);

…/routing/dynamic-route-collision.test.js …/routing/dynamic-route-collision.test.tspackages/astro/test/units/routing/dynamic-route-collision.test.js renamed to packages/astro/test/units/routing/dynamic-route-collision.test.ts packages/astro/test/units/routing/dynamic-route-collision.test.js renamed to packages/astro/test/units/routing/dynamic-route-collision.test.ts

@@ -1,16 +1,26 @@
 import assert from 'node:assert/strict';
 import { describe, it, before, beforeEach } from 'node:test';
+import type { ComponentInstance } from '../../../dist/types/astro.js';
+import type { LogMessage, LogWritable } from '../../../dist/core/logger/core.js';
 import { Logger } from '../../../dist/core/logger/core.js';
 import { RouteCache, callGetStaticPaths } from '../../../dist/core/render/route-cache.js';
 import { dynamicPart, makeRoute } from './test-helpers.js';
 
+function mod(overrides: Partial<ComponentInstance>): ComponentInstance {
+	return overrides as ComponentInstance;
+}
+
 describe('getStaticPaths caching behavior', () => {
-	let routeCache;
-	let logger;
-	let callCount;
+	let routeCache: RouteCache;
+	let logger: Logger;
+	let callCount: number;
+
+	const dest: LogWritable<LogMessage> = {
+		write: () => true,
+	};
 
 	before(() => {
-		logger = new Logger({ dest: 'memory', level: 'error' });
+		logger = new Logger({ dest, level: 'error' });
 	});
 
 	beforeEach(() => {
@@ -28,17 +38,16 @@ describe('getStaticPaths caching behavior', () => {
 			prerender: true,
 		});
 
-		const mod = {
-			default: () => {},
+		const testMod = mod({
 			getStaticPaths: async () => {
 				callCount++;
 				return [{ params: { param: 'a' } }, { params: { param: 'b' } }, { params: { param: 'c' } }];
 			},
-		};
+		});
 
 		// First call should execute getStaticPaths
 		const result1 = await callGetStaticPaths({
-			mod,
+			mod: testMod,
 			route,
 			routeCache,
 			ssr: false,
@@ -51,7 +60,7 @@ describe('getStaticPaths caching behavior', () => {
 
 		// Second call should use cache
 		const result2 = await callGetStaticPaths({
-			mod,
+			mod: testMod,
 			route,
 			routeCache,
 			ssr: false,
@@ -65,7 +74,7 @@ describe('getStaticPaths caching behavior', () => {
 
 		// Third call should also use cache
 		const result3 = await callGetStaticPaths({
-			mod,
+			mod: testMod,
 			route,
 			routeCache,
 			ssr: false,
@@ -87,17 +96,16 @@ describe('getStaticPaths caching behavior', () => {
 			prerender: true,
 		});
 
-		const mod = {
-			default: () => {},
+		const testMod = mod({
 			getStaticPaths: async () => {
 				callCount++;
 				return [{ params: { test: 'value' } }];
 			},
-		};
+		});
 
 		// First call
 		await callGetStaticPaths({
-			mod,
+			mod: testMod,
 			route,
 			routeCache,
 			ssr: false,
@@ -112,7 +120,7 @@ describe('getStaticPaths caching behavior', () => {
 
 		// Second call after clearing should call getStaticPaths again
 		await callGetStaticPaths({
-			mod,
+			mod: testMod,
 			route,
 			routeCache,
 			ssr: false,

…tro/test/units/routing/generator.test.js …tro/test/units/routing/generator.test.tspackages/astro/test/units/routing/generator.test.js renamed to packages/astro/test/units/routing/generator.test.ts packages/astro/test/units/routing/generator.test.js renamed to packages/astro/test/units/routing/generator.test.ts

@@ -1,15 +1,25 @@
 import assert from 'node:assert/strict';
 import { describe, it, before } from 'node:test';
+import type { ComponentInstance } from '../../../dist/types/astro.js';
+import type { LogMessage, LogWritable } from '../../../dist/core/logger/core.js';
 import { Logger } from '../../../dist/core/logger/core.js';
 import { RouteCache, callGetStaticPaths } from '../../../dist/core/render/route-cache.js';
 import { makeRoute } from './test-helpers.js';
 
+function mod(overrides: Partial<ComponentInstance>): ComponentInstance {
+	return overrides as ComponentInstance;
+}
+
 describe('getStaticPaths param validation', () => {
-	let routeCache;
-	let logger;
+	let routeCache: RouteCache;
+	let logger: Logger;
+
+	const dest: LogWritable<LogMessage> = {
+		write: () => true,
+	};
 
 	before(() => {
-		logger = new Logger({ dest: 'memory', level: 'error' });
+		logger = new Logger({ dest, level: 'error' });
 		routeCache = new RouteCache(logger, 'production');
 	});
 
@@ -43,18 +53,18 @@ describe('getStaticPaths param validation', () => {
 			// Clear route cache before each test to ensure isolation
 			routeCache.clearAll();
 
-			const mod = {
-				default: () => {},
+			const testMod = mod({
 				getStaticPaths: async () => [
 					{
-						params: { testParam: value },
+						// Intentionally passing invalid param types to test validation
+						params: { testParam: value as string | undefined },
 					},
 				],
-			};
+			});
 
 			try {
 				await callGetStaticPaths({
-					mod,
+					mod: testMod,
 					route,
 					routeCache,
 					ssr: false,
@@ -65,7 +75,7 @@ describe('getStaticPaths param validation', () => {
 				if (!shouldPass) {
 					assert.fail(`Expected validation error for param type ${type}`);
 				}
-			} catch (err) {
+			} catch (err: any) {
 				if (shouldPass) {
 					throw err;
 				}

…its/routing/getstaticpaths-cache.test.js …its/routing/getstaticpaths-cache.test.tspackages/astro/test/units/routing/getstaticpaths-cache.test.js renamed to packages/astro/test/units/routing/getstaticpaths-cache.test.ts packages/astro/test/units/routing/getstaticpaths-cache.test.js renamed to packages/astro/test/units/routing/getstaticpaths-cache.test.ts

@@ -1,10 +1,11 @@
 import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
+import type { AstroConfig } from '../../../dist/types/public/config.js';
 import { Router } from '../../../dist/core/routing/router.js';
 import { dynamicPart, makeRoute, staticPart } from './test-helpers.js';
 
 describe('preview routing (unit)', () => {
-	const routes = (trailingSlash) => [
+	const routes = (trailingSlash: AstroConfig['trailingSlash']) => [
 		makeRoute({ segments: [], trailingSlash, route: '/', pathname: '/', isIndex: true }),
 		makeRoute({
 			segments: [[staticPart('another')]],

…/units/routing/params-validation.test.js …/units/routing/params-validation.test.tspackages/astro/test/units/routing/params-validation.test.js renamed to packages/astro/test/units/routing/params-validation.test.ts packages/astro/test/units/routing/params-validation.test.js renamed to packages/astro/test/units/routing/params-validation.test.ts

@@ -1,4 +1,4 @@
-import * as assert from 'node:assert/strict';
+import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
 import { Router } from '../../../dist/core/routing/router.js';
 import { dynamicPart, makeRoute, staticPart } from './test-helpers.js';

…tro/test/units/routing/prerender.test.js …tro/test/units/routing/prerender.test.tspackages/astro/test/units/routing/prerender.test.js renamed to packages/astro/test/units/routing/prerender.test.ts packages/astro/test/units/routing/prerender.test.js renamed to packages/astro/test/units/routing/prerender.test.ts

@@ -181,6 +181,7 @@ describe('setOriginPathname / getOriginPathname', () => {
 
 	it('handles undefined pathname', () => {
 		const req = new Request('http://example.com/');
+		// @ts-expect-error Testing runtime behavior with undefined pathname
 		setOriginPathname(req, undefined, 'ignore', 'directory');
 		assert.equal(getOriginPathname(req), '/');
 	});