ci: improve caching and combine eslint with build job

Author: wopian

.github/workflows/build.yml

@@ -2,30 +2,36 @@ name: Build
 on: [push, pull_request]
 jobs:
   build:
-    name: Node ${{ matrix.node_version }} on ${{ matrix.os }}
+    name: Build (${{ matrix.node_version}}-${{ matrix.os }})
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         node_version: [10, 12, 14]
         os: [ubuntu-latest, windows-latest, macos-latest]
     steps:
-    - uses: actions/checkout@v2
+    - name: Checkout repository
+      uses: actions/checkout@v2
     - name: Use node ${{ matrix.node_version }}
       uses: actions/setup-node@v1
       with:
         node-version: ${{ matrix.node_version }}
-    - name: Restore lerna cache
+    - name: Restore cache
       uses: actions/cache@v2
       with:
         path: |
           node_modules
           */*/node_modules
-        key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
+        key: ${{ matrix.os }}-${{ matrix.node_version}}-yarn-${{ hashFiles('**/yarn.lock') }}
+        restore-keys: ${{ matrix.os }}-${{ matrix.node_version }}-yarn-
     - name: Install yarn dependencies
       run: yarn install
-    - run: yarn bootstrap
-    - name: Build package
+    - name: Bootstrap lerna packages
+      run: yarn bootstrap
+    - name: Build lerna packages
       run: yarn build
-    - name: Check built package sizes
+    - name: Lint source code
+      run: yarn lint
+      if: matrix.node_version == 14 && matrix.os == 'ubuntu-latest'
+    - name: Lint package sizes
       run: yarn size
       if: matrix.node_version == 14 && matrix.os == 'ubuntu-latest'

.github/workflows/codeql-analysis.yml

@@ -1,17 +1,15 @@
-name: "CodeQL"
+name: Code Scanning
 
 on:
   push:
-    branches: [master, 9.x]
+    branches: [master]
   pull_request:
-    # The branches below must be a subset of the branches above
-    branches: [master, 9.x]
+    branches: [master]
   schedule:
-    - cron: '0 6 * * 1'
+    - cron: '0 0 * * 0'
 
 jobs:
-  analyse:
-    name: Analyse
+  codeQL:
     runs-on: ubuntu-latest
 
     steps:
@@ -30,9 +28,8 @@ jobs:
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v1
-      # Override language selection by uncommenting this and choosing your languages
-      # with:
-      #   languages: go, javascript, csharp, python, cpp, java
+      with:
+        languages: javascript
 
     # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
     # If this step fails, then you should remove it and run the build manually (see below)

.github/workflows/eslint.yml

@@ -2,35 +2,39 @@ name: Unit Tests
 on: [push, pull_request]
 jobs:
   jest:
-    name: Node ${{ matrix.node_version }} on ${{ matrix.os }}
+    name: Jest (${{ matrix.node_version}}-${{ matrix.os }})
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         node_version: [10, 12, 14]
         os: [ubuntu-latest, windows-latest, macos-latest]
     steps:
-    - uses: actions/checkout@v2
+    - name: Checkout repository
+      uses: actions/checkout@v2
     - name: Use node ${{ matrix.node_version }}
       uses: actions/setup-node@v1
       with:
         node-version: ${{ matrix.node_version }}
-    - name: Restore lerna cache
+    - name: Restore cache
       uses: actions/cache@v2
       with:
         path: |
           node_modules
           */*/node_modules
-        key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
+        key: ${{ matrix.os }}-${{ matrix.node_version}}-yarn-${{ hashFiles('**/yarn.lock') }}
+        restore-keys: ${{ matrix.os }}-${{ matrix.node_version }}-yarn-
     - name: Install yarn dependencies
       run: yarn install
+    - name: Bootstrap lerna packages
+      run: yarn bootstrap
     - name: Jest with code coverage
-      if: (matrix.node_version == 14 && matrix.os == 'ubuntu-latest')
+      if: matrix.node_version == 14 && matrix.os == 'ubuntu-latest'
       uses: mattallty/jest-github-action@v1.0.3
       with:
         changes-only: true
         test-command: 'yarn test:coverage'
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     - name: Jest
-      if: (matrix.node_version != 14 || matrix.os != 'ubuntu-latest')
+      if: matrix.node_version != 14 || matrix.os != 'ubuntu-latest'
       run: yarn jest