fix(kitsu-core): optional chain constructor calls to allow invalid JSON values

Closes #416

Author: wopian

packages/kitsu-core/src/deattribute/index.js

@@ -29,7 +29,7 @@
 export function deattribute (data) {
   if (typeof data === 'object' && data !== null) {
     if (Array.isArray(data)) data.map(el => deattribute(el))
-    else if (data.attributes && data.attributes.constructor === Object) {
+    else if (data.attributes?.constructor === Object) {
       for (const key of Object.keys(data.attributes)) {
         // Hoist everything but attributes to parent to avoid issues with deleting
         // as can't delete data.attributes[key] as it will belete data[key] too

packages/kitsu-core/src/serialise/index.js

@@ -24,7 +24,7 @@ function isValid (isArray, type, payload, method) {
       }
     }
   } else {
-    if (payload.constructor !== Object || Object.keys(payload).length === 0) {
+    if (payload?.constructor !== Object || Object.keys(payload).length === 0) {
       throw new Error(`${method} requires an object or array body`)
     }
     // A POST request is the only request to not require an ID in spec
@@ -146,7 +146,7 @@ function serialiseRootObject (type, payload, method, options) {
     const node = payload[key]
     const nodeType = options.pluralTypes(options.camelCaseTypes(key))
     // 1. Skip null nodes, 2. Only grab objects, 3. Filter to only serialise relationable objects
-    if (node !== null && node.constructor === Object && hasID(node)) {
+    if (node !== null && node?.constructor === Object && hasID(node)) {
       data = serialiseObject(node, nodeType, key, data, method)
     // 1. Skip null nodes, 2. Only grab arrays, 3. Filter to only serialise relationable arrays
     } else if (node !== null && Array.isArray(node) && (node.length > 0 && hasID(node[0]))) {

packages/kitsu-core/src/serialise/index.spec.js

@@ -422,5 +422,13 @@ describe('kitsu-core', () => {
         data: [ resourceOutput, resourceOutput ]
       })
     })
+
+    it('does not error with an invalid JSON value (undefined)', () => {
+      expect.assertions(1)
+      const resource = { id: '1', content: undefined }
+      const resourceOutput = { id: '1', type: 'posts', attributes: { content: undefined } }
+      const input = serialise('posts', resource)
+      expect(input).toEqual({ data: resourceOutput })
+    })
   })
 })