Skip to content

Commit 85a192b

Browse files
committed
feat(kitsu): delete - add param parameter
BREAKING CHANGE
1 parent c55949a commit 85a192b

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

packages/kitsu/src/delete.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ describe('kitsu', () => {
2222
})
2323
return [ 200 ]
2424
})
25-
api.delete('anime', 1, { extra: true }).catch(err => {
25+
api.delete('anime', 1, { headers: { extra: true } }).catch(err => {
2626
done.fail(err)
2727
})
2828
done()

packages/kitsu/src/index.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -316,15 +316,19 @@ export default class Kitsu {
316316
* @memberof Kitsu
317317
* @param {string} model Model to remove data from
318318
* @param {string|number|number[]} id Resource ID to remove. Pass an array of IDs to delete multiple resources (Bulk Extension)
319-
* @param {Object} [headers] Additional headers to send with the request
319+
* @param {Object} [config] Additional configuration
320+
* @param {Object} [config.params] JSON:API request queries. See [#get](#get) for documentation
321+
* @param {Object} [config.headers] Additional headers to send with the request
320322
* @returns {Object|Object[]} JSON-parsed response
321323
* @example <caption>Remove a single resource</caption>
322324
* api.delete('posts', 123)
323325
* @example <caption>Remove multiple resources (API must support the Bulk Extension)</caption>
324326
* api.delete('posts', [ 1, 2 ])
325327
*/
326-
async delete (model, id, headers = {}) {
328+
async delete (model, id, config = {}) {
327329
try {
330+
const headers = merge(this.headers, config.headers)
331+
const params = merge({}, config.params)
328332
const [ resourceModel, url ] = splitModel(model, {
329333
resourceCase: this.resCase,
330334
pluralModel: this.plural
@@ -345,7 +349,9 @@ export default class Kitsu {
345349
camelCaseTypes: this.camel,
346350
pluralTypes: this.plural
347351
}),
348-
headers: Object.assign(this.headers, headers)
352+
headers,
353+
params,
354+
paramsSerializer: /* istanbul ignore next */ p => query(p)
349355
})
350356

351357
return data

0 commit comments

Comments
 (0)