Adding sub relationships for routes with 4 subpaths#552
Merged
wopian merged 5 commits intowopian:masterfrom Jun 7, 2021
Merged
Adding sub relationships for routes with 4 subpaths#552wopian merged 5 commits intowopian:masterfrom
wopian merged 5 commits intowopian:masterfrom
Conversation
Contributor
Author
|
Confused what to do here? |
PRs from forks do not have access to the secret variable. According to CodeClimate, this is a public read-only token and doesn't need to be kept secret: https://docs.codeclimate.com/docs/finding-your-test-coverage-token#should-i-keep-my-test-reporter-id-secret
|
Code Climate has analyzed commit 6406e9d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
wopian
added a commit
that referenced
this pull request
Jun 7, 2021
* Adding sub relationships for routes with 4 subpaths * test(kitsu): add coverage for fetching relationships of a resource * ci(codeclimate): move public identifier into workflow PRs from forks do not have access to the secret variable. According to CodeClimate, this is a public read-only token and doesn't need to be kept secret: https://docs.codeclimate.com/docs/finding-your-test-coverage-token#should-i-keep-my-test-reporter-id-secret * docs: fix jsdoc syntax Co-authored-by: wopian <wopian@wopian.me>
Owner
|
Thank you for the PR! I have added test coverage for the new lines of code. Released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening this pull request on a new branch. An example of this is https://kitsu.io/api/edge/media-relationships/10743/relationships/destination