Fix: Pick the meta object from actual resource rather from cached res…#783
Fix: Pick the meta object from actual resource rather from cached res…#783wopian merged 6 commits intowopian:masterfrom
Conversation
…ource if it is different
|
Please can you fix the linter errors and warnings in the PR. You can run You can ignore the complexity warning flagged by Codeclimate |
|
Sure, will resolve these and update you soon. |
mountainfirefly
force-pushed
the
master
branch
from
85c46c2 to
913531d
Compare
|
@wopian I have addressed your review comments. |
wopian
left a comment
wopian
left a comment
There was a problem hiding this comment.
Please run yarn lint --fix to resolve the lining errors and warnings from ESLint
| const objKeys1 = Object.keys(object1); | ||
| const objKeys2 = Object.keys(object2); |
There was a problem hiding this comment.
Function should check both values are objects before contining to access Object.keys on them.
Tests are failing due to undefined and null values being passed in through object1 and/or object2.
|
@wopian Your review comments have been addressed, please check now. Thanks |
|
Code Climate has analyzed commit a66f183 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
|
Thank you. I updated the tests to include coverage of the uncovered branches and added the sample you gave in the issue as a test case in |
|
Released in 10.0.3 (2022-10-30) |
|
Thank you so much @wopian . |
2 participants
…ource if it is different