Skip to content

Commit 339a1d1

Browse files
committed
Merge pull request #2264 from wordpress-mobile/issue/2222-theme-preview-title
issue/2222 theme preview title
2 parents 37d0a62 + 13f6afd commit 339a1d1

File tree

2 files changed

+25
-10
lines changed

2 files changed

+25
-10
lines changed

WordPress/src/main/java/org/wordpress/android/ui/themes/ThemePreviewFragment.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,11 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
134134
mWebView.getSettings().setUserAgentString(DESKTOP_UA);
135135
mWebView.setScrollBarStyle(View.SCROLLBARS_INSIDE_OVERLAY);
136136

137-
mWebView.setWebChromeClient(new WPWebChromeClient(getActivity(), (ProgressBar) view.findViewById(
138-
R.id.progress_bar)));
137+
mWebView.setWebChromeClient(
138+
new WPWebChromeClient(
139+
getActivity(),
140+
(ProgressBar) view.findViewById(R.id.progress_bar),
141+
false));
139142

140143
mWebView.setWebViewClient(new WPWebViewClient(mBlog));
141144

libs/utils/WordPressUtils/src/main/java/org/wordpress/android/util/WPWebChromeClient.java

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,35 @@
77
import android.widget.ProgressBar;
88

99
public class WPWebChromeClient extends WebChromeClient {
10-
private ProgressBar mProgressBar;
11-
private Activity mActivity;
10+
private final ProgressBar mProgressBar;
11+
private final Activity mActivity;
12+
private final boolean mAutoUpdateActivityTitle;
1213

1314
public WPWebChromeClient(Activity activity, ProgressBar progressBar) {
15+
mActivity = activity;
1416
mProgressBar = progressBar;
17+
mAutoUpdateActivityTitle = true;
18+
}
19+
20+
public WPWebChromeClient(Activity activity,
21+
ProgressBar progressBar,
22+
boolean autoUpdateActivityTitle) {
1523
mActivity = activity;
24+
mProgressBar = progressBar;
25+
mAutoUpdateActivityTitle = autoUpdateActivityTitle;
1626
}
1727

1828
public void onProgressChanged(WebView webView, int progress) {
19-
if (!mActivity.isFinishing()) {
29+
if (mActivity != null && !mActivity.isFinishing() && mAutoUpdateActivityTitle) {
2030
mActivity.setTitle(webView.getTitle());
2131
}
22-
if (progress == 100) {
23-
mProgressBar.setVisibility(View.GONE);
24-
} else {
25-
mProgressBar.setVisibility(View.VISIBLE);
26-
mProgressBar.setProgress(progress);
32+
if (mProgressBar != null) {
33+
if (progress == 100) {
34+
mProgressBar.setVisibility(View.GONE);
35+
} else {
36+
mProgressBar.setVisibility(View.VISIBLE);
37+
mProgressBar.setProgress(progress);
38+
}
2739
}
2840
}
2941
}

0 commit comments

Comments
 (0)