RS Post Settings: Simplify code and remove redundant patterns

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: nbradbury

WordPress/src/main/java/org/wordpress/android/ui/postsrs/PostRsSettingsActivity.kt

@@ -162,7 +162,7 @@ class PostRsSettingsActivity : BaseAppCompatActivity() {
                         MediaPickerConstants.EXTRA_MEDIA_URIS
                     )
                 val uri = uris?.firstOrNull()
-                    ?.let { it.toUri() }
+                    ?.toUri()
                 if (uri != null) {
                     viewModel.onFeaturedImagePickedFromDevice(
                         uri

WordPress/src/main/java/org/wordpress/android/ui/postsrs/PostRsSettingsViewModel.kt

@@ -560,7 +560,7 @@ class PostRsSettingsViewModel @Inject constructor(
     ): Long {
         val client = apiClient
             ?: throw PostApiRequestException(
-                "No API client"
+                "No site selected"
             )
         val response = client.request { requestBuilder ->
             requestBuilder.media().create(

WordPress/src/main/java/org/wordpress/android/ui/postsrs/screens/PostRsSettingsScreen.kt

@@ -593,8 +593,8 @@ private fun HeroImagePlaceholder(
     text: String = stringResource(
         R.string.post_rs_settings_featured_image_not_set
     ),
-    onChooseFromWpMedia: (() -> Unit)? = null,
-    onChooseFromDevice: (() -> Unit)? = null,
+    onChooseFromWpMedia: () -> Unit,
+    onChooseFromDevice: () -> Unit,
 ) {
     Box(
         modifier = Modifier
@@ -611,19 +611,14 @@ private fun HeroImagePlaceholder(
                 .onSurfaceVariant,
             modifier = Modifier.align(Alignment.Center)
         )
-        if (
-            onChooseFromWpMedia != null &&
-            onChooseFromDevice != null
-        ) {
-            FeaturedImageEditButton(
-                hasImage = false,
-                onChooseFromWpMedia = onChooseFromWpMedia,
-                onChooseFromDevice = onChooseFromDevice,
-                modifier = Modifier
-                    .align(Alignment.BottomEnd)
-                    .padding(12.dp)
-            )
-        }
+        FeaturedImageEditButton(
+            hasImage = false,
+            onChooseFromWpMedia = onChooseFromWpMedia,
+            onChooseFromDevice = onChooseFromDevice,
+            modifier = Modifier
+                .align(Alignment.BottomEnd)
+                .padding(12.dp)
+        )
     }
 }