Removed unused updateEmailPostsFrequency

Author: nbradbury

WordPress/src/main/java/org/wordpress/android/ui/reader/subscription/ReaderBlogSubscriptionUseCase.kt

@@ -1,6 +1,8 @@
 package org.wordpress.android.ui.reader.subscription
 
 import kotlinx.coroutines.CoroutineDispatcher
+import kotlinx.coroutines.flow.MutableSharedFlow
+import kotlinx.coroutines.flow.first
 import kotlinx.coroutines.withContext
 import org.greenrobot.eventbus.Subscribe
 import org.greenrobot.eventbus.ThreadMode
@@ -11,23 +13,18 @@ import org.wordpress.android.fluxc.store.AccountStore
 import org.wordpress.android.fluxc.store.AccountStore.AddOrDeleteSubscriptionPayload
 import org.wordpress.android.fluxc.store.AccountStore.AddOrDeleteSubscriptionPayload.SubscriptionAction
 import org.wordpress.android.fluxc.store.AccountStore.OnSubscriptionUpdated
-import org.wordpress.android.fluxc.store.AccountStore.UpdateSubscriptionPayload
-import org.wordpress.android.fluxc.store.AccountStore.UpdateSubscriptionPayload.SubscriptionFrequency
 import org.wordpress.android.modules.BG_THREAD
 import org.wordpress.android.util.NetworkUtilsWrapper
 import javax.inject.Inject
 import javax.inject.Named
-import kotlin.coroutines.Continuation
-import kotlin.coroutines.resume
-import kotlin.coroutines.suspendCoroutine
 
 class ReaderBlogSubscriptionUseCase @Inject constructor(
     private val dispatcher: Dispatcher,
     private val accountStore: AccountStore,
     private val networkUtilsWrapper: NetworkUtilsWrapper,
     @Named(BG_THREAD) private val bgDispatcher: CoroutineDispatcher
 ) {
-    private var updateContinuation: Continuation<UpdateResult>? = null
+    private val updateResultFlow = MutableSharedFlow<UpdateResult>(extraBufferCapacity = 1)
 
     init {
         dispatcher.register(this)
@@ -45,43 +42,30 @@ class ReaderBlogSubscriptionUseCase @Inject constructor(
         if (!networkUtilsWrapper.isNetworkAvailable()) {
             return UpdateResult.NoNetwork
         }
-        return suspendCoroutine { continuation ->
-            updateContinuation = continuation
-            val action = if (enable) SubscriptionAction.NEW else SubscriptionAction.DELETE
-            val payload = AddOrDeleteSubscriptionPayload(blogId.toString(), action)
-            dispatcher.dispatch(AccountActionBuilder.newUpdateSubscriptionNotificationPostAction(payload))
-        }
+        val action = if (enable) SubscriptionAction.NEW else SubscriptionAction.DELETE
+        val payload = AddOrDeleteSubscriptionPayload(blogId.toString(), action)
+        dispatcher.dispatch(AccountActionBuilder.newUpdateSubscriptionNotificationPostAction(payload))
+        return updateResultFlow.first()
     }
 
     suspend fun updateEmailPosts(blogId: Long, enable: Boolean): UpdateResult {
         if (!networkUtilsWrapper.isNetworkAvailable()) {
             return UpdateResult.NoNetwork
         }
-        return suspendCoroutine { continuation ->
-            updateContinuation = continuation
-            val action = if (enable) SubscriptionAction.NEW else SubscriptionAction.DELETE
-            val payload = AddOrDeleteSubscriptionPayload(blogId.toString(), action)
-            dispatcher.dispatch(AccountActionBuilder.newUpdateSubscriptionEmailPostAction(payload))
-        }
+        val action = if (enable) SubscriptionAction.NEW else SubscriptionAction.DELETE
+        val payload = AddOrDeleteSubscriptionPayload(blogId.toString(), action)
+        dispatcher.dispatch(AccountActionBuilder.newUpdateSubscriptionEmailPostAction(payload))
+        return updateResultFlow.first()
     }
 
-    suspend fun updateEmailPostsFrequency(blogId: Long, frequency: SubscriptionFrequency): UpdateResult =
-        suspendCoroutine { continuation ->
-            updateContinuation = continuation
-            val payload = UpdateSubscriptionPayload(blogId.toString(), frequency)
-            dispatcher.dispatch(AccountActionBuilder.newUpdateSubscriptionEmailPostFrequencyAction(payload))
-        }
-
     suspend fun updateEmailComments(blogId: Long, enable: Boolean): UpdateResult {
         if (!networkUtilsWrapper.isNetworkAvailable()) {
             return UpdateResult.NoNetwork
         }
-        return suspendCoroutine { continuation ->
-            updateContinuation = continuation
-            val action = if (enable) SubscriptionAction.NEW else SubscriptionAction.DELETE
-            val payload = AddOrDeleteSubscriptionPayload(blogId.toString(), action)
-            dispatcher.dispatch(AccountActionBuilder.newUpdateSubscriptionEmailCommentAction(payload))
-        }
+        val action = if (enable) SubscriptionAction.NEW else SubscriptionAction.DELETE
+        val payload = AddOrDeleteSubscriptionPayload(blogId.toString(), action)
+        dispatcher.dispatch(AccountActionBuilder.newUpdateSubscriptionEmailCommentAction(payload))
+        return updateResultFlow.first()
     }
 
     fun refreshSubscriptions() {
@@ -96,8 +80,7 @@ class ReaderBlogSubscriptionUseCase @Inject constructor(
         } else {
             UpdateResult.Success
         }
-        updateContinuation?.resume(result)
-        updateContinuation = null
+        updateResultFlow.tryEmit(result)
 
         // Refresh subscriptions after successful update
         if (!event.isError) {