Add second non-essential step to test array

Adds a step that always fails and registers it in
the non-essential array to verify multi-entry gating.

---

Generated with the help of Claude Code, https://claude.ai/code

Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>

Author: mokagio

.buildkite/commands/upload-claude-analysis.sh

@@ -9,7 +9,7 @@ source .buildkite/shared-pipeline-vars
 
 # Non-essential steps whose failure alone should NOT trigger Claude analysis.
 # Add step keys here as needed.
-NON_ESSENTIAL_STEPS=("danger")
+NON_ESSENTIAL_STEPS=("danger" "test-non-essential")
 
 # Count how many non-essential steps have a "failed" outcome.
 non_essential_failures=0

.buildkite/pipeline.yml

@@ -37,6 +37,12 @@ steps:
         agents:
           queue: "linter"
 
+      - label: ":test_tube: Non-essential test step"
+        command: "echo 'This step always fails for testing' && exit 1"
+        key: test-non-essential
+        agents:
+          queue: "linter"
+
       - label: "🕵️ checkstyle"
         command: |
           if .buildkite/commands/should-skip-job.sh --job-type validation; then