Merge pull request #30 from fancyboi999/fix/provider-config-recreate

fix: recreate provider instances on config change

Author: idoubi

src-api/src/core/agent/registry.ts

@@ -12,6 +12,7 @@ import type {
   AgentProvider,
   IAgent,
 } from '@/core/agent/types';
+import { isDeepEqualConfig } from '@/shared/utils/config';
 
 // ============================================================================
 // Agent Instance State
@@ -165,10 +166,31 @@ class AgentRegistry {
    */
   async getInstance(type: string, config?: AgentConfig): Promise<IAgent> {
     let instanceData = this.instances.get(type);
+    const effectiveConfig: AgentConfig = {
+      ...(config ?? {}),
+      provider: type as AgentProvider,
+    };
 
     if (instanceData && instanceData.state === 'ready') {
-      instanceData.lastUsedAt = new Date();
-      return instanceData.agent;
+      if (isDeepEqualConfig(instanceData.config, effectiveConfig)) {
+        instanceData.lastUsedAt = new Date();
+        return instanceData.agent;
+      }
+      try {
+        const agentWithShutdown = instanceData.agent as {
+          shutdown?: () => Promise<void>;
+        };
+        if (typeof agentWithShutdown.shutdown === 'function') {
+          await agentWithShutdown.shutdown();
+        }
+      } catch (error) {
+        console.warn(
+          `[${this.registryName}] Failed to shutdown provider ${type}:`,
+          error
+        );
+      }
+      this.instances.delete(type);
+      instanceData = undefined;
     }
 
     // If instance exists but is in error state, try to recreate
@@ -181,7 +203,6 @@ class AgentRegistry {
     }
 
     // Create new instance
-    const effectiveConfig = config || { provider: type as AgentProvider };
     const agent = this.create(type, effectiveConfig);
     instanceData = {
       agent,

src-api/src/core/sandbox/registry.ts

@@ -16,6 +16,7 @@ import type {
   SandboxProviderRegistry,
   SandboxProviderType,
 } from '@/core/sandbox/types';
+import { isDeepEqualConfig } from '@/shared/utils/config';
 
 // ============================================================================
 // Sandbox Instance State
@@ -162,8 +163,20 @@ class SandboxRegistry implements SandboxProviderRegistry {
     let instanceData = this.instances.get(type);
 
     if (instanceData && instanceData.state === 'ready') {
-      instanceData.lastUsedAt = new Date();
-      return instanceData.provider;
+      if (isDeepEqualConfig(instanceData.config, config)) {
+        instanceData.lastUsedAt = new Date();
+        return instanceData.provider;
+      }
+      try {
+        await instanceData.provider.shutdown();
+      } catch (error) {
+        console.warn(
+          `[${this.registryName}] Failed to shutdown provider ${type}:`,
+          error
+        );
+      }
+      this.instances.delete(type);
+      instanceData = undefined;
     }
 
     // If instance exists but is in error state, try to recreate

src-api/src/shared/utils/config.ts

@@ -0,0 +1,44 @@
+/**
+ * Configuration normalization helpers
+ *
+ * Provides stable serialization for config comparison.
+ */
+
+function normalizeValue(value: unknown): unknown {
+  if (value === undefined) {
+    return undefined;
+  }
+  if (value === null) {
+    return null;
+  }
+  if (value instanceof Date) {
+    return value.toISOString();
+  }
+  if (typeof value === 'bigint') {
+    return value.toString();
+  }
+  if (Array.isArray(value)) {
+    return value.map((item) => normalizeValue(item));
+  }
+  if (typeof value === 'object') {
+    const obj = value as Record<string, unknown>;
+    const keys = Object.keys(obj).sort();
+    const normalized: Record<string, unknown> = {};
+    for (const key of keys) {
+      const normalizedValue = normalizeValue(obj[key]);
+      if (normalizedValue !== undefined) {
+        normalized[key] = normalizedValue;
+      }
+    }
+    return normalized;
+  }
+  return value;
+}
+
+export function stableStringify(value: unknown): string {
+  return JSON.stringify(normalizeValue(value));
+}
+
+export function isDeepEqualConfig(a: unknown, b: unknown): boolean {
+  return stableStringify(a) === stableStringify(b);
+}