fixup: read key inside method

Author: wutschel

XBMC Remote/SettingsValuesViewController.m

@@ -232,7 +232,7 @@ - (NSString*)getActionButtonTitle {
             subTitle = [NSString stringWithFormat:@": %@", settingOptions[longPressRow.row][@"label"]];
             break;
         case cSlider:
-            stringFormat = [self getStringFormatFromItem:itemControls[@"formatlabel"] defaultFormat:stringFormat];
+            stringFormat = [self getStringFormatFromItem:itemControls defaultFormat:stringFormat];
             subTitle = [NSString stringWithFormat:stringFormat, (int)storeSliderValue];
             break;
         case cUnsupported:
@@ -344,9 +344,10 @@ - (void)retrieveXBMCData:(NSString*)method parameters:(NSDictionary*)params item
 
 #pragma mark Helper
 
-- (NSString*)getStringFormatFromItem:(NSString*)format defaultFormat:(NSString*)defaultFormat {
+- (NSString*)getStringFormatFromItem:(id)item defaultFormat:(NSString*)defaultFormat {
     // Workaround!! Before Kodi 18.x an older format ("%i ms") was used. The new format ("{0:d} ms") needs
     // an updated parser. Until this is implemented just display the value itself, without the unit.
+    NSString *format = item[@"formatlabel"];
     if (format.length > 0 && AppDelegate.instance.serverVersion < 18) {
         return format;
     }
@@ -534,7 +535,7 @@ - (UITableViewCell*)tableView:(UITableView*)tableView cellForRowAtIndexPath:(NSI
             slider.minimumValue = [self.detailItem[@"minimum"] intValue];
             slider.maximumValue = [self.detailItem[@"maximum"] intValue];
             slider.value = [self.detailItem[@"value"] intValue];
-            stringFormat = [self getStringFormatFromItem:itemControls[@"formatlabel"] defaultFormat:stringFormat];
+            stringFormat = [self getStringFormatFromItem:itemControls defaultFormat:stringFormat];
             sliderLabel.text = [NSString stringWithFormat:stringFormat, [self.detailItem[@"value"] intValue]];
             break;
 
@@ -795,7 +796,7 @@ - (void)sliderAction:(id)sender {
         if ([[[slider superview] viewWithTag:102] isKindOfClass:[UILabel class]]) {
             UILabel *sliderLabel = (UILabel*)[[slider superview] viewWithTag:102];
             NSString *stringFormat = @"%i";
-            stringFormat = [self getStringFormatFromItem:itemControls[@"formatlabel"] defaultFormat:stringFormat];
+            stringFormat = [self getStringFormatFromItem:itemControls defaultFormat:stringFormat];
             sliderLabel.text = [NSString stringWithFormat:stringFormat, (int)storeSliderValue];
         }
     }