[DashTree] Allow generate segment beyond period boudaries

Author: CastagnaIT

src/parser/DASHTree.cpp

@@ -1050,6 +1050,8 @@ void adaptive::CDashTree::ParseTagRepresentation(pugi::xml_node nodeRepr,
         else if (repr->HasSegmentEndNr())
           segNumberEnd = repr->GetSegmentEndNr();
 
+        //const bool isComplete
+
         GenerateTemplatedSegments(*segTemplate, periodStartMs, periodDurMs, segNumberEnd,
                                   repr->Timeline(), nowMs);
       }
@@ -1825,8 +1827,17 @@ void adaptive::CDashTree::GenerateTemplatedSegments(PLAYLIST::CSegmentTemplate&
 
   const uint64_t timeEnd = wndEnd * segTimescale / 1000;
 
-  // Create segments within time window
-  while (time + segDuration <= timeEnd && segNumber <= segNumberEnd)
+  // Create segments within time window,
+  // a segment that begins within the period and partially
+  // extends beyond the period boundaries must still be generated
+  //! @todo: currently when a segment extends beyond the period boundaries
+  //! it will exist also on next period, this will cause duplicate playback of the content (you can see also twice downloads)
+  //! in theory this should be fixed in the sample reader, where the sample packets of a segment
+  //! (at the beginning or end) must be filtered based on the duration of the period.
+  //! In other words, finish playing a segment early by skipping the samples that fall outside the period,
+  //! while in the next period, start playing the segment from a sample with a specific PTS,
+  //! thus skipping part of the initial samples.
+  while (time < timeEnd && segNumber <= segNumberEnd)
   {
     CSegment seg;
     seg.startPTS_ = time;

src/test/TestDASHTree.cpp

@@ -285,7 +285,7 @@ TEST_F(DASHTreeTest, CalculateCorrectSegmentNumbersFromSegmentTemplateWithOldPub
 
   auto& segments = tree->m_periods[0]->GetAdaptationSets()[0]->GetRepresentations()[0]->Timeline();
 
-  EXPECT_EQ(segments.GetSize(), 30);
+  EXPECT_EQ(segments.GetSize(), 31);
   EXPECT_EQ(segments.Get(0)->m_number, 603271);
 }
 
@@ -712,16 +712,16 @@ TEST_F(DASHTreeTest, SegmentTemplateStartNumber)
 
   // Verify segments
   auto& rep1Timeline = adpSets[0]->GetRepresentations()[0]->Timeline();
-  EXPECT_EQ(rep1Timeline.GetSize(), 143);
+  EXPECT_EQ(rep1Timeline.GetSize(), 144);
 
   EXPECT_EQ(rep1Timeline.Get(0)->startPTS_, 0);
   EXPECT_EQ(rep1Timeline.Get(0)->m_number, 0);
 
   EXPECT_EQ(rep1Timeline.Get(1)->startPTS_, 48000);
   EXPECT_EQ(rep1Timeline.Get(1)->m_number, 1);
 
-  EXPECT_EQ(rep1Timeline.Get(142)->startPTS_, 6816000);
-  EXPECT_EQ(rep1Timeline.Get(142)->m_number, 142);
+  EXPECT_EQ(rep1Timeline.Get(143)->startPTS_, 6864000);
+  EXPECT_EQ(rep1Timeline.Get(143)->m_number, 143);
 }
 
 TEST_F(DASHTreeTest, TSBMiddlePeriods)
@@ -743,9 +743,9 @@ TEST_F(DASHTreeTest, TSBMiddlePeriods)
   auto& tlPeriod2 =
       tree->m_periods[1]->GetAdaptationSets()[0]->GetRepresentations()[0]->Timeline();
 
-  EXPECT_EQ(tlPeriod2.GetSize(), 2);
+  EXPECT_EQ(tlPeriod2.GetSize(), 3);
   EXPECT_EQ(tlPeriod2.GetFront()->m_number, 856065420);
-  EXPECT_EQ(tlPeriod2.GetBack()->m_number, 856065421);
+  EXPECT_EQ(tlPeriod2.GetBack()->m_number, 856065422);
 }
 
 TEST_F(DASHTreeTest, TSBMiddlePeriodsPastNowTime)
@@ -778,9 +778,9 @@ TEST_F(DASHTreeTest, TSBAvailabilityStartTime)
   auto& tl =
       tree->m_periods[0]->GetAdaptationSets()[0]->GetRepresentations()[0]->Timeline();
 
-  EXPECT_EQ(tl.GetSize(), 1200);
+  EXPECT_EQ(tl.GetSize(), 1201);
   EXPECT_EQ(tl.GetFront()->m_number, 129069);
-  EXPECT_EQ(tl.GetBack()->m_number, 130268);
+  EXPECT_EQ(tl.GetBack()->m_number, 130269);
 }
 
 TEST_F(DASHTreeTest, TSBUTCTimingDirect1)