[chooser][demux] Fix screen resolution false positives and audio deadlock on STREAMCHANGE

Fix 1: Screen Resolution False Positives
CRepresentationChooserDefault::CheckResolution() compared the
user-configured resolution limit (m_screenWidth) against the actual
physical hardware resolution (m_screenCurrentWidth), resulting in
perpetual false positives every 10 seconds. Dedicated tracking
variables (m_screenLastWidth, m_screenLastHeight) now correctly
isolate physical window resize detection from the addon's maximum
quality configuration limits.

Fix 2: Audio Deadlock on Quality STREAMCHANGE
When a bandwidth fluctuation triggered a representation change, Kodi
Core reopened all active streams sequentially. If the first stream
(Video) evaluated to no quality change, the m_checkCoreReopen
optimization flag short-circuited all further OpenStream callbacks.
If a subsequent stream (Audio) did change quality, its Reset() and
reconstruction was skipped entirely, leaving it stuck at
EVENT_TYPE::REP_CHANGE and permanently blocking segment downloads.

This commit hoists a !streamChanged conditional to guard the entire
m_checkCoreReopen block, guaranteeing that a formally changed stream
bypasses the fast-path optimization and executes its native Reset()
cycle.

Author: linzack

src/common/ChooserDefault.cpp

@@ -91,6 +91,9 @@ void CRepresentationChooserDefault::SetSecureSession(const bool isSecureSession)
 
 void CRepresentationChooserDefault::PostInit()
 {
+  m_screenLastWidth = m_screenCurrentWidth;
+  m_screenLastHeight = m_screenCurrentHeight;
+
   RefreshResolution();
 
   if (!m_bandwidthInitAuto)
@@ -116,7 +119,7 @@ void CRepresentationChooserDefault::PostInit()
 
 void CRepresentationChooserDefault::CheckResolution()
 {
-  if (m_screenWidth != m_screenCurrentWidth || m_screenHeight != m_screenCurrentHeight)
+  if (m_screenLastWidth != m_screenCurrentWidth || m_screenLastHeight != m_screenCurrentHeight)
   {
     // Update the screen resolution values only after n seconds
     // to prevent too fast update when Kodi window will be resized
@@ -128,6 +131,8 @@ void CRepresentationChooserDefault::CheckResolution()
       return;
     }
     RefreshResolution();
+    m_screenLastWidth = m_screenCurrentWidth;
+    m_screenLastHeight = m_screenCurrentHeight;
     m_screenResLastUpdate = std::chrono::steady_clock::now();
     LOG::Log(LOGDEBUG, "[Repr. chooser] Screen resolution has changed: %ix%i", m_screenCurrentWidth,
              m_screenCurrentHeight);

src/common/ChooserDefault.h

@@ -49,6 +49,8 @@ class ATTR_DLL_LOCAL CRepresentationChooserDefault : public IRepresentationChoos
 
   int m_screenWidth{0};
   int m_screenHeight{0};
+  int m_screenLastWidth{0};
+  int m_screenLastHeight{0};
   std::optional<std::chrono::steady_clock::time_point> m_screenResLastUpdate;
 
   std::pair<int, int> m_screenResMax; // Max resolution for non-protected video content

src/main.cpp

@@ -221,7 +221,9 @@ bool CInputStreamAdaptive::OpenStream(int streamid)
     }
   }
 
-  if (m_checkCoreReopen)
+  bool streamChanged{stream->m_adStream.StreamChanged()};
+
+  if (m_checkCoreReopen && !streamChanged)
   {
     LOG::Log(LOGDEBUG, "OpenStream(%d): The stream has already been opened", streamid);
     return false;