refactor: resolve v14-only API references at runtime for v13 compat

Author: konradmichalik

Classes/EventListener/ModifyRecordListRecordActionsListener.php

@@ -15,7 +15,6 @@
 
 use Doctrine\DBAL\Exception;
 use TYPO3\CMS\Backend\RecordList\Event\ModifyRecordListRecordActionsEvent;
-use TYPO3\CMS\Backend\Template\Components\ActionGroup;
 use TYPO3\CMS\Core\Attribute\AsEventListener;
 use TYPO3\CMS\Core\Domain\RecordInterface;
 use TYPO3\CMS\Core\Imaging\{IconFactory, IconSize};
@@ -28,6 +27,7 @@
 use Xima\XimaTypo3ContentPlanner\Utility\ExtensionUtility;
 use Xima\XimaTypo3ContentPlanner\Utility\Security\PermissionUtility;
 
+use function constant;
 use function count;
 use function is_array;
 
@@ -60,7 +60,7 @@ public function __invoke(ModifyRecordListRecordActionsEvent $event): void
             return;
         }
         // TYPO3 v13/v14 compatibility: In v14 getRecord() returns RecordInterface, in v13 it returns array
-        // @phpstan-ignore instanceof.alwaysTrue, method.notFound
+        // @phpstan-ignore instanceof.alwaysTrue, instanceof.alwaysFalse, method.notFound
         $table = $event->getRecord() instanceof RecordInterface ? $event->getRecord()->getMainType() : $event->getTable();
 
         if (!ExtensionUtility::isRegisteredRecordTable($table) || $event->hasAction('Status')) {
@@ -73,7 +73,7 @@ public function __invoke(ModifyRecordListRecordActionsEvent $event): void
         }
 
         // TYPO3 v13/v14 compatibility: In v14 getRecord() returns RecordInterface, in v13 it returns array
-        // @phpstan-ignore instanceof.alwaysTrue
+        // @phpstan-ignore instanceof.alwaysTrue, instanceof.alwaysFalse, method.notFound, offsetAccess.nonOffsetAccessible
         $uid = $event->getRecord() instanceof RecordInterface ? $event->getRecord()->getUid() : $event->getRecord()['uid'];
 
         // ToDo: this is necessary cause the status is not in the record, pls check tca for this
@@ -101,10 +101,16 @@ public function __invoke(ModifyRecordListRecordActionsEvent $event): void
             $dropDownButton->addItem($actionToAdd);
         }
 
+        // ActionGroup::primary is v14-only; resolve via constant() at runtime
+        // so PHPStan does not need to know the v14 enum when analysing v13.
+        $primaryGroup = VersionUtility::is14OrHigher()
+            ? constant('TYPO3\\CMS\\Backend\\Template\\Components\\ActionGroup::primary')
+            : 'primary';
+
         $event->setAction(
             VersionUtility::is14OrHigher() ? $dropDownButton : $dropDownButton->render(),
             'Status',
-            VersionUtility::is14OrHigher() ? ActionGroup::primary : 'primary',
+            $primaryGroup,
             'delete',
         );
     }

Classes/Utility/Compatibility/ComponentFactoryUtility.php

@@ -28,6 +28,7 @@ class ComponentFactoryUtility
     public static function createDropDownButton(): DropDownButton
     {
         if (VersionUtility::is14OrHigher()) {
+            // @phpstan-ignore method.notFound
             return self::getComponentFactory()->createDropDownButton();
         }
 
@@ -37,6 +38,7 @@ public static function createDropDownButton(): DropDownButton
     public static function createDropDownItem(): DropDownItem
     {
         if (VersionUtility::is14OrHigher()) {
+            // @phpstan-ignore method.notFound
             return self::getComponentFactory()->createDropDownItem();
         }
 
@@ -46,6 +48,7 @@ public static function createDropDownItem(): DropDownItem
     public static function createDropDownDivider(): DropDownDivider
     {
         if (VersionUtility::is14OrHigher()) {
+            // @phpstan-ignore method.notFound
             return self::getComponentFactory()->createDropDownDivider();
         }
 
@@ -55,20 +58,24 @@ public static function createDropDownDivider(): DropDownDivider
     public static function createDropDownHeader(): DropDownHeader
     {
         if (VersionUtility::is14OrHigher()) {
+            // @phpstan-ignore method.notFound
             return self::getComponentFactory()->createDropDownHeader();
         }
 
         return GeneralUtility::makeInstance(DropDownHeader::class);
     }
 
     /**
-     * @return \TYPO3\CMS\Backend\Template\Components\ComponentFactory
+     * Returns the v14-only ComponentFactory instance. Return type is `object`
+     * (not the FQN) so PHPStan does not have to resolve the v14 class when
+     * analysing against TYPO3 v13.
      */
     private static function getComponentFactory(): object
     {
-        // Use dynamic class name to avoid autoload issues on TYPO3 13
+        // Dynamic class name to avoid autoload issues on TYPO3 13
         $componentFactoryClass = 'TYPO3\\CMS\\Backend\\Template\\Components\\ComponentFactory';
 
+        // @phpstan-ignore argument.type
         return GeneralUtility::makeInstance($componentFactoryClass);
     }
 }

Classes/Utility/Rendering/AssetUtility.php

@@ -15,8 +15,6 @@
 
 use Psr\Http\Message\ServerRequestInterface;
 use TYPO3\CMS\Core\Resource\Exception\InvalidFileException;
-use TYPO3\CMS\Core\SystemResource\Publishing\{SystemResourcePublisherInterface, UriGenerationOptions};
-use TYPO3\CMS\Core\SystemResource\SystemResourceFactory;
 use TYPO3\CMS\Core\Utility\{GeneralUtility, PathUtility};
 use Xima\XimaTypo3ContentPlanner\Utility\Compatibility\VersionUtility;
 
@@ -75,18 +73,27 @@ public static function getJsTag(
     public static function getPublicResourcePath(string $resourcePath): string
     {
         if (VersionUtility::is14OrHigher()) {
-            /** @var SystemResourceFactory $resourceFactory */
-            $resourceFactory = GeneralUtility::makeInstance(SystemResourceFactory::class);
-            /** @var SystemResourcePublisherInterface $resourcePublisher */
-            $resourcePublisher = GeneralUtility::makeInstance(SystemResourcePublisherInterface::class);
+            // FQN strings to keep PHPStan happy when analysing against TYPO3 v13,
+            // where these classes do not exist. Runtime path is v14-only anyway.
+            $factoryClass = 'TYPO3\\CMS\\Core\\SystemResource\\SystemResourceFactory';
+            $publisherClass = 'TYPO3\\CMS\\Core\\SystemResource\\Publishing\\SystemResourcePublisherInterface';
+            $optionsClass = 'TYPO3\\CMS\\Core\\SystemResource\\Publishing\\UriGenerationOptions';
+
+            // @phpstan-ignore argument.type
+            $resourceFactory = GeneralUtility::makeInstance($factoryClass);
+            // @phpstan-ignore argument.type
+            $resourcePublisher = GeneralUtility::makeInstance($publisherClass);
+            // @phpstan-ignore class.notFound, method.notFound
             $resource = $resourceFactory->createPublicResource($resourcePath);
             /** @var ServerRequestInterface|null $request */
             $request = $GLOBALS['TYPO3_REQUEST'] ?? null;
 
+            // @phpstan-ignore class.notFound, method.notFound
             return (string) $resourcePublisher->generateUri(
                 $resource,
                 $request,
-                new UriGenerationOptions(absoluteUri: false),
+                // @phpstan-ignore class.notFound
+                new $optionsClass(absoluteUri: false),
             );
         }