Breaking change: remove duplicate TOML attribute (#116)

Author: xoofx

site/docs/serialization.md

@@ -206,7 +206,7 @@ so you can reuse models across JSON and TOML. When both are present, the TOML-sp
 
 | Attribute | JSON equivalent | Description |
 | --- | --- | --- |
-| [`TomlPropertyNameAttribute`](xref:Tomlyn.TomlPropertyNameAttribute) | [`JsonPropertyNameAttribute`](xref:System.Text.Json.Serialization.JsonPropertyNameAttribute) | Overrides the serialized key name. |
+| [`TomlPropertyNameAttribute`](xref:Tomlyn.Serialization.TomlPropertyNameAttribute) | [`JsonPropertyNameAttribute`](xref:System.Text.Json.Serialization.JsonPropertyNameAttribute) | Overrides the serialized key name. |
 | [`TomlIgnoreAttribute`](xref:Tomlyn.Serialization.TomlIgnoreAttribute) | [`JsonIgnoreAttribute`](xref:System.Text.Json.Serialization.JsonIgnoreAttribute) | Ignores the member. Supports conditions (`Never`, `WhenWritingNull`, `WhenWritingDefault`). |
 | [`TomlIncludeAttribute`](xref:Tomlyn.Serialization.TomlIncludeAttribute) | [`JsonIncludeAttribute`](xref:System.Text.Json.Serialization.JsonIncludeAttribute) | Includes non-public members. |
 | [`TomlPropertyOrderAttribute`](xref:Tomlyn.Serialization.TomlPropertyOrderAttribute) | [`JsonPropertyOrderAttribute`](xref:System.Text.Json.Serialization.JsonPropertyOrderAttribute) | Controls ordering within tables. |

site/docs/source-generation.md

@@ -91,7 +91,7 @@ internal partial class MyTomlContext : TomlSerializerContext { }
 
 For source generation, member names are resolved **at build time** using:
 
-1. [`TomlPropertyNameAttribute`](xref:Tomlyn.TomlPropertyNameAttribute) / [`JsonPropertyNameAttribute`](xref:System.Text.Json.Serialization.JsonPropertyNameAttribute) (when present - these override naming policies).
+1. [`TomlPropertyNameAttribute`](xref:Tomlyn.Serialization.TomlPropertyNameAttribute) / [`JsonPropertyNameAttribute`](xref:System.Text.Json.Serialization.JsonPropertyNameAttribute) (when present - these override naming policies).
 2. [`TomlSourceGenerationOptionsAttribute.PropertyNamingPolicy`](xref:Tomlyn.Serialization.TomlSourceGenerationOptionsAttribute) (when no explicit name attribute).
 
 The generated serializer stores the resolved names directly and does **not** call `ConvertName(...)` at runtime.
@@ -102,7 +102,7 @@ The source generator supports these attributes at compile time:
 
 | Member-level | Type-level |
 | --- | --- |
-| [`JsonPropertyNameAttribute`](xref:System.Text.Json.Serialization.JsonPropertyNameAttribute) / [`TomlPropertyNameAttribute`](xref:Tomlyn.TomlPropertyNameAttribute) | [`JsonConstructorAttribute`](xref:System.Text.Json.Serialization.JsonConstructorAttribute) / [`TomlConstructorAttribute`](xref:Tomlyn.Serialization.TomlConstructorAttribute) |
+| [`JsonPropertyNameAttribute`](xref:System.Text.Json.Serialization.JsonPropertyNameAttribute) / [`TomlPropertyNameAttribute`](xref:Tomlyn.Serialization.TomlPropertyNameAttribute) | [`JsonConstructorAttribute`](xref:System.Text.Json.Serialization.JsonConstructorAttribute) / [`TomlConstructorAttribute`](xref:Tomlyn.Serialization.TomlConstructorAttribute) |
 | [`JsonIgnoreAttribute`](xref:System.Text.Json.Serialization.JsonIgnoreAttribute) / [`TomlIgnoreAttribute`](xref:Tomlyn.Serialization.TomlIgnoreAttribute) | [`JsonPolymorphicAttribute`](xref:System.Text.Json.Serialization.JsonPolymorphicAttribute) / [`TomlPolymorphicAttribute`](xref:Tomlyn.Serialization.TomlPolymorphicAttribute) |
 | [`JsonIncludeAttribute`](xref:System.Text.Json.Serialization.JsonIncludeAttribute) / [`TomlIncludeAttribute`](xref:Tomlyn.Serialization.TomlIncludeAttribute) | [`JsonDerivedTypeAttribute`](xref:System.Text.Json.Serialization.JsonDerivedTypeAttribute) / [`TomlDerivedTypeAttribute`](xref:Tomlyn.Serialization.TomlDerivedTypeAttribute) |
 | [`JsonPropertyOrderAttribute`](xref:System.Text.Json.Serialization.JsonPropertyOrderAttribute) / [`TomlPropertyOrderAttribute`](xref:Tomlyn.Serialization.TomlPropertyOrderAttribute) | |

src/Tomlyn.Tests/NewApiAttributeContractTests.cs

@@ -0,0 +1,53 @@
+using System;
+using System.Linq;
+using NUnit.Framework;
+using Tomlyn.Serialization;
+
+namespace Tomlyn.Tests;
+
+public class NewApiAttributeContractTests
+{
+    [Test]
+    public void ExportedTomlAttributes_HaveUniqueTypeNames()
+    {
+        var duplicateNames = typeof(TomlSerializer).Assembly
+            .GetExportedTypes()
+            .Where(static type => type.Name.StartsWith("Toml", StringComparison.Ordinal) &&
+                                  type.Name.EndsWith("Attribute", StringComparison.Ordinal))
+            .GroupBy(static type => type.Name, StringComparer.Ordinal)
+            .Where(static group => group.Count() > 1)
+            .Select(static group => group.Key)
+            .ToArray();
+
+        Assert.That(duplicateNames, Is.Empty);
+    }
+
+    [Test]
+    public void ExportedTomlAttributes_InheritTomlAttribute()
+    {
+        var nonDerivedAttributes = typeof(TomlSerializer).Assembly
+            .GetExportedTypes()
+            .Where(static type => type != typeof(TomlAttribute) &&
+                                  type.IsSubclassOf(typeof(Attribute)) &&
+                                  type.Name.StartsWith("Toml", StringComparison.Ordinal) &&
+                                  type.Name.EndsWith("Attribute", StringComparison.Ordinal))
+            .Where(static type => !typeof(TomlAttribute).IsAssignableFrom(type))
+            .Select(static type => type.FullName)
+            .ToArray();
+
+        Assert.That(nonDerivedAttributes, Is.Empty);
+    }
+
+    [Test]
+    public void TomlPropertyNameAttribute_IsOnlyAvailableFromSerializationNamespace()
+    {
+        var exportedTypes = typeof(TomlSerializer).Assembly
+            .GetExportedTypes()
+            .Where(static type => type.Name == nameof(TomlPropertyNameAttribute))
+            .Select(static type => type.FullName)
+            .OrderBy(static fullName => fullName, StringComparer.Ordinal)
+            .ToArray();
+
+        Assert.That(exportedTypes, Is.EqualTo(new[] { "Tomlyn.Serialization.TomlPropertyNameAttribute" }));
+    }
+}